From: Jimmy Assarsson <extja@kvaser.com>
To: linux-can@vger.kernel.org
Cc: Jimmy Assarsson <jimmyassarsson@gmail.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Jimmy Assarsson <extja@kvaser.com>
Subject: [PATCH 8/9] can: kvaser_pciefd: Expose device firmware version via devlink info_get()
Date: Wed, 23 Jul 2025 10:32:35 +0200 [thread overview]
Message-ID: <20250723083236.9-9-extja@kvaser.com> (raw)
In-Reply-To: <20250723083236.9-1-extja@kvaser.com>
Expose device firmware version via devlink info_get().
Example output:
$ devlink dev
pci/0000:07:00.0
pci/0000:08:00.0
pci/0000:09:00.0
$ devlink dev info
pci/0000:07:00.0:
driver kvaser_pciefd
versions:
running:
fw 1.3.75
pci/0000:08:00.0:
driver kvaser_pciefd
versions:
running:
fw 2.4.29
pci/0000:09:00.0:
driver kvaser_pciefd
versions:
running:
fw 1.3.72
Signed-off-by: Jimmy Assarsson <extja@kvaser.com>
---
.../can/kvaser_pciefd/kvaser_pciefd_devlink.c | 26 +++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/drivers/net/can/kvaser_pciefd/kvaser_pciefd_devlink.c b/drivers/net/can/kvaser_pciefd/kvaser_pciefd_devlink.c
index 8145d25943de..b6d3745089d4 100644
--- a/drivers/net/can/kvaser_pciefd/kvaser_pciefd_devlink.c
+++ b/drivers/net/can/kvaser_pciefd/kvaser_pciefd_devlink.c
@@ -4,7 +4,33 @@
* Copyright (C) 2025 KVASER AB, Sweden. All rights reserved.
*/
+#include "kvaser_pciefd.h"
+
#include <net/devlink.h>
+static int kvaser_pciefd_devlink_info_get(struct devlink *devlink,
+ struct devlink_info_req *req,
+ struct netlink_ext_ack *extack)
+{
+ struct kvaser_pciefd *pcie = devlink_priv(devlink);
+ char buf[14]; /* xxx.xxx.xxxxx */
+ int ret;
+
+ if (pcie->fw_version.major) {
+ snprintf(buf, sizeof(buf), "%u.%u.%u",
+ pcie->fw_version.major,
+ pcie->fw_version.minor,
+ pcie->fw_version.build);
+ ret = devlink_info_version_running_put(req,
+ DEVLINK_INFO_VERSION_GENERIC_FW,
+ buf);
+ if (ret)
+ return ret;
+ }
+
+ return 0;
+}
+
const struct devlink_ops kvaser_pciefd_devlink_ops = {
+ .info_get = kvaser_pciefd_devlink_info_get,
};
--
2.49.0
next prev parent reply other threads:[~2025-07-23 8:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 8:32 [PATCH 0/9] can: kvaser_pciefd: Simplify identification of physical CAN interfaces Jimmy Assarsson
2025-07-23 8:32 ` [PATCH 1/9] can: kvaser_pciefd: Add support to control CAN LEDs on device Jimmy Assarsson
2025-07-23 12:09 ` Vincent Mailhol
2025-07-24 6:48 ` Jimmy Assarsson
2025-07-23 8:32 ` [PATCH 2/9] can: kvaser_pciefd: Add support for ethtool set_phys_id() Jimmy Assarsson
2025-07-23 12:14 ` Vincent Mailhol
2025-07-23 8:32 ` [PATCH 3/9] can: kvaser_pciefd: Add intermediate variable for device struct in probe() Jimmy Assarsson
2025-07-23 8:32 ` [PATCH 4/9] can: kvaser_pciefd: Store the different firmware version components in a struct Jimmy Assarsson
2025-07-23 12:17 ` Vincent Mailhol
2025-07-23 8:32 ` [PATCH 5/9] can: kvaser_pciefd: Store device channel index Jimmy Assarsson
2025-07-23 12:27 ` Vincent Mailhol
2025-07-24 7:05 ` Jimmy Assarsson
2025-07-24 7:48 ` Vincent Mailhol
2025-07-23 8:32 ` [PATCH 6/9] can: kvaser_pciefd: Split driver into C-file and header-file Jimmy Assarsson
2025-07-23 8:32 ` [PATCH 7/9] can: kvaser_pciefd: Add devlink support Jimmy Assarsson
2025-07-23 12:31 ` Vincent Mailhol
2025-07-23 12:36 ` Marc Kleine-Budde
2025-07-23 12:46 ` Vincent Mailhol
2025-07-23 8:32 ` Jimmy Assarsson [this message]
2025-07-23 12:33 ` [PATCH 8/9] can: kvaser_pciefd: Expose device firmware version via devlink info_get() Vincent Mailhol
2025-07-23 8:32 ` [PATCH 9/9] can: kvaser_pciefd: Add devlink port support Jimmy Assarsson
2025-07-23 12:37 ` [PATCH 0/9] can: kvaser_pciefd: Simplify identification of physical CAN interfaces Vincent Mailhol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250723083236.9-9-extja@kvaser.com \
--to=extja@kvaser.com \
--cc=jimmyassarsson@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox