From: Jimmy Assarsson <extja@kvaser.com>
To: linux-can@vger.kernel.org
Cc: Jimmy Assarsson <jimmyassarsson@gmail.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Subject: [PATCH 2/9] can: kvaser_usb: Add support for ethtool set_phys_id()
Date: Wed, 23 Jul 2025 10:35:01 +0200 [thread overview]
Message-ID: <20250723083508.40-3-extja@kvaser.com> (raw)
In-Reply-To: <20250723083508.40-1-extja@kvaser.com>
Add support for ethtool set_phys_id(), to physically locate devices by
flashing a LED on the device.
Signed-off-by: Jimmy Assarsson <extja@kvaser.com>
---
.../net/can/usb/kvaser_usb/kvaser_usb_core.c | 29 +++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c b/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c
index daf42080f942..8003c3662247 100644
--- a/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c
+++ b/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c
@@ -753,6 +753,34 @@ static netdev_tx_t kvaser_usb_start_xmit(struct sk_buff *skb,
return ret;
}
+static int kvaser_usb_set_phys_id(struct net_device *netdev,
+ enum ethtool_phys_id_state state)
+{
+ struct kvaser_usb_net_priv *priv = netdev_priv(netdev);
+ const struct kvaser_usb_dev_ops *ops = priv->dev->driver_info->ops;
+ int ret = 0;
+
+ switch (state) {
+ case ETHTOOL_ID_ACTIVE:
+ return 3; /* 3 On/Off cycles per second */
+ case ETHTOOL_ID_ON:
+ ret = ops->dev_set_led(priv, KVASER_USB_LED_ON, 1000);
+ break;
+ case ETHTOOL_ID_OFF:
+ ret = ops->dev_set_led(priv, KVASER_USB_LED_OFF, 1000);
+ break;
+ case ETHTOOL_ID_INACTIVE:
+ /* Turn LED off and restore standard function after 1ms */
+ ret = ops->dev_set_led(priv, KVASER_USB_LED_OFF, 1);
+ break;
+ default:
+ ret = -EINVAL;
+ break;
+ }
+
+ return ret;
+}
+
static const struct net_device_ops kvaser_usb_netdev_ops = {
.ndo_open = kvaser_usb_open,
.ndo_stop = kvaser_usb_close,
@@ -763,6 +791,7 @@ static const struct net_device_ops kvaser_usb_netdev_ops = {
static const struct ethtool_ops kvaser_usb_ethtool_ops = {
.get_ts_info = can_ethtool_op_get_ts_info_hwts,
+ .set_phys_id = kvaser_usb_set_phys_id,
};
static void kvaser_usb_remove_interfaces(struct kvaser_usb *dev)
--
2.49.0
next prev parent reply other threads:[~2025-07-23 8:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 8:34 [PATCH 0/9] can: kvaser_usb: Simplify identification of physical CAN interfaces Jimmy Assarsson
2025-07-23 8:35 ` [PATCH 1/9] can: kvaser_usb: Add support to control CAN LEDs on device Jimmy Assarsson
2025-07-23 8:35 ` Jimmy Assarsson [this message]
2025-07-23 8:35 ` [PATCH 3/9] can: kvaser_usb: Add intermediate variables Jimmy Assarsson
2025-07-23 8:35 ` [PATCH 4/9] can: kvaser_usb: Move comment regarding max_tx_urbs Jimmy Assarsson
2025-07-23 8:35 ` [PATCH 5/9] can: kvaser_usb: Store the different firmware version components in a struct Jimmy Assarsson
2025-07-23 8:35 ` [PATCH 6/9] can: kvaser_usb: Store additional device information Jimmy Assarsson
2025-07-23 8:35 ` [PATCH 7/9] can: kvaser_usb: Add devlink support Jimmy Assarsson
2025-07-23 8:35 ` [PATCH 8/9] can: kvaser_usb: Expose device information via devlink info_get() Jimmy Assarsson
2025-07-23 8:35 ` [PATCH 9/9] can: kvaser_usb: Add devlink port support Jimmy Assarsson
2025-07-23 12:44 ` [PATCH 0/9] can: kvaser_usb: Simplify identification of physical CAN interfaces Vincent Mailhol
2025-07-24 6:43 ` Jimmy Assarsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250723083508.40-3-extja@kvaser.com \
--to=extja@kvaser.com \
--cc=jimmyassarsson@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox