From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Stephane Grosjean <stephane.grosjean@free.fr>
Cc: linux-can Mailing List <linux-can@vger.kernel.org>,
Stephane Grosjean <stephane.grosjean@hms-networks.com>
Subject: Re: [PATCH v2] can: peak_usb: fix USB FD devices potential malfunction
Date: Fri, 25 Jul 2025 12:12:05 +0200 [thread overview]
Message-ID: <20250725-married-fearless-carp-adb86d-mkl@pengutronix.de> (raw)
In-Reply-To: <20250725-whimsical-finicky-sambar-5202a2-mkl@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
On 25.07.2025 10:33:25, Marc Kleine-Budde wrote:
> On 24.07.2025 10:13:19, Stephane Grosjean wrote:
> > From: Stephane Grosjean <stephane.grosjean@hms-networks.com>
> >
> > The latest firmware versions of USB CAN FD interfaces export the EP numbers
> > to be used to dialog with the device via the "type" field of a response to
> > a vendor request structure, particularly when its value is greater than or
> > equal to 2.
> >
> > This patch corrects the driver's test of this field.
Rephrased to: "Correct the driver's test of this field.". This part of
the patch description should use imperative language.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2025-07-25 10:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 8:13 [PATCH v2] can: peak_usb: fix USB FD devices potential malfunction Stephane Grosjean
2025-07-25 8:33 ` Marc Kleine-Budde
2025-07-25 10:12 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250725-married-fearless-carp-adb86d-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=stephane.grosjean@free.fr \
--cc=stephane.grosjean@hms-networks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).