From: Vincent Mailhol <mailhol@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
Oliver Hartkopp <socketcan@hartkopp.net>
Cc: "Vincent Mailhol" <mailhol@kernel.org>,
"Stéphane Grosjean" <stephane.grosjean@hms-networks.com>,
"Robert Nawrath" <mbro1689@gmail.com>,
"Minh Le" <minh.le.aj@renesas.com>,
"Duy Nguyen" <duy.nguyen.rh@renesas.com>,
linux-can@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 08/20] can: netlink: remove useless check in can_tdc_changelink()
Date: Wed, 10 Sep 2025 15:03:33 +0900 [thread overview]
Message-ID: <20250910-canxl-netlink-prep-v2-8-f128d4083721@kernel.org> (raw)
In-Reply-To: <20250910-canxl-netlink-prep-v2-0-f128d4083721@kernel.org>
can_tdc_changelink() return -EOPNOTSUPP under this condition:
!tdc_const || !can_fd_tdc_is_enabled(priv)
But this function is only called if the data[IFLA_CAN_TDC] parameters
are provided. At this point, can_validate_tdc() already checked that
either of the tdc auto or tdc manual control modes were provided, that
is to say, can_fd_tdc_is_enabled(priv) must be true.
Because the right hand operand of this condition is always true,
remove it.
Signed-off-by: Vincent Mailhol <mailhol@kernel.org>
---
drivers/net/can/dev/netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/dev/netlink.c b/drivers/net/can/dev/netlink.c
index 72a82d4e9d6494771320ea035ed6f6098c0e8ce6..33a6621bd7a916583802fa12e0bd971c89560924 100644
--- a/drivers/net/can/dev/netlink.c
+++ b/drivers/net/can/dev/netlink.c
@@ -179,7 +179,7 @@ static int can_tdc_changelink(struct can_priv *priv, const struct nlattr *nla,
const struct can_tdc_const *tdc_const = priv->fd.tdc_const;
int err;
- if (!tdc_const || !can_fd_tdc_is_enabled(priv))
+ if (!tdc_const)
return -EOPNOTSUPP;
err = nla_parse_nested(tb_tdc, IFLA_CAN_TDC_MAX, nla,
--
2.49.1
next prev parent reply other threads:[~2025-09-10 6:04 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 6:03 [PATCH v2 00/20] can: netlink: preparation before introduction of CAN XL step 2/2 Vincent Mailhol
2025-09-10 6:03 ` [PATCH v2 01/20] can: dev: move struct data_bittiming_params to linux/can/bittiming.h Vincent Mailhol
2025-09-10 6:03 ` [PATCH v2 02/20] can: dev: make can_get_relative_tdco() FD agnostic and move it to bittiming.h Vincent Mailhol
2025-09-10 6:03 ` [PATCH v2 03/20] can: netlink: document which symbols are FD specific Vincent Mailhol
2025-09-10 6:03 ` [PATCH v2 04/20] can: netlink: refactor can_validate_bittiming() Vincent Mailhol
2025-09-10 6:13 ` Marc Kleine-Budde
2025-09-10 6:43 ` Vincent Mailhol
2025-09-10 10:55 ` Marc Kleine-Budde
2025-09-10 11:12 ` Vincent Mailhol
2025-09-10 6:03 ` [PATCH v2 05/20] can: netlink: add can_validate_tdc() Vincent Mailhol
2025-09-10 6:03 ` [PATCH v2 06/20] can: netlink: add can_validate_databittiming() Vincent Mailhol
2025-09-10 6:03 ` [PATCH v2 07/20] can: netlink: refactor CAN_CTRLMODE_TDC_{AUTO,MANUAL} flag reset logic Vincent Mailhol
2025-09-20 7:24 ` Vincent Mailhol
2025-09-22 9:43 ` Marc Kleine-Budde
2025-09-22 11:14 ` Vincent Mailhol
2025-09-22 13:06 ` Marc Kleine-Budde
2025-09-23 7:04 ` Vincent Mailhol
2025-09-23 9:08 ` Marc Kleine-Budde
2025-09-23 9:36 ` Vincent Mailhol
2025-09-10 6:03 ` Vincent Mailhol [this message]
2025-09-10 6:03 ` [PATCH v2 09/20] can: netlink: make can_tdc_changelink() FD agnostic Vincent Mailhol
2025-09-10 6:03 ` [PATCH v2 10/20] can: netlink: add can_dtb_changelink() Vincent Mailhol
2025-09-10 6:03 ` [PATCH v2 11/20] can: netlink: add can_ctrlmode_changelink() Vincent Mailhol
2025-09-10 6:03 ` [PATCH v2 12/20] can: netlink: make can_tdc_get_size() FD agnostic Vincent Mailhol
2025-09-10 6:03 ` [PATCH v2 13/20] can: netlink: add can_data_bittiming_get_size() Vincent Mailhol
2025-09-10 6:03 ` [PATCH v2 14/20] can: netlink: add can_bittiming_fill_info() Vincent Mailhol
2025-09-10 6:03 ` [PATCH v2 15/20] can: netlink: add can_bittiming_const_fill_info() Vincent Mailhol
2025-09-10 6:03 ` [PATCH v2 16/20] can: netlink: add can_bitrate_const_fill_info() Vincent Mailhol
2025-09-10 6:03 ` [PATCH v2 17/20] can: netlink: make can_tdc_fill_info() FD agnostic Vincent Mailhol
2025-09-10 6:03 ` [PATCH v2 18/20] can: calc_bittiming: make can_calc_tdco() " Vincent Mailhol
2025-09-10 6:03 ` [PATCH v2 19/20] can: dev: add can_get_ctrlmode_str() Vincent Mailhol
2025-09-10 6:03 ` [PATCH v2 20/20] can: netlink: add userland error messages Vincent Mailhol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250910-canxl-netlink-prep-v2-8-f128d4083721@kernel.org \
--to=mailhol@kernel.org \
--cc=duy.nguyen.rh@renesas.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbro1689@gmail.com \
--cc=minh.le.aj@renesas.com \
--cc=mkl@pengutronix.de \
--cc=socketcan@hartkopp.net \
--cc=stephane.grosjean@hms-networks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).