linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Vincent Mailhol <mailhol@kernel.org>
Cc: netdev@vger.kernel.org,
	Stephen Hemminger <stephen@networkplumber.org>,
	 David Ahern <dsahern@gmail.com>,
	Oliver Hartkopp <socketcan@hartkopp.net>,
	 linux-kernel@vger.kernel.org, linux-can@vger.kernel.org
Subject: Re: [PATCH iproute2-next 0/3] iplink_can: fix checkpatch.pl warnings
Date: Mon, 22 Sep 2025 10:42:23 +0200	[thread overview]
Message-ID: <20250922-astute-impressive-skink-36e51a-mkl@pengutronix.de> (raw)
In-Reply-To: <20250921-iplink_can-checkpatch-fixes-v1-0-1ddab98560cd@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 932 bytes --]

On 21.09.2025 16:32:29, Vincent Mailhol wrote:
> This is a clean up series which goes through all the checkpatch
> warnings on ip/iplink_can.c and fixes them one by one. By the end on
> this series, there is only one warning left:
> 
>   WARNING: Prefer __printf(2, 0) over __attribute__((format(printf, 2, 0)))
>   #320: FILE: ip/iplink_can.c:320:
>   +static void __attribute__((format(printf, 2, 0)))
> 
> Because iproute2 does not declare the __printf() macro, that last one
> can not be fixed.
> 
> Signed-off-by: Vincent Mailhol <mailhol@kernel.org>

For the whole series:

Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2025-09-22  8:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-21  7:32 [PATCH iproute2-next 0/3] iplink_can: fix checkpatch.pl warnings Vincent Mailhol
2025-09-21  7:32 ` [PATCH iproute2-next 1/3] iplink_can: fix coding style for pointer format Vincent Mailhol
2025-09-22 22:10   ` Stephen Hemminger
2025-09-23  2:07     ` Vincent Mailhol
2025-09-21  7:32 ` [PATCH iproute2-next 2/3] iplink_can: fix SPDX-License-Identifier tag format Vincent Mailhol
2025-09-22 22:08   ` Stephen Hemminger
2025-09-21  7:32 ` [PATCH iproute2-next 3/3] iplink_can: factorise the calls to usage() Vincent Mailhol
2025-09-22 22:09   ` Stephen Hemminger
2025-09-22  8:42 ` Marc Kleine-Budde [this message]
2025-09-25 16:40 ` [PATCH iproute2-next 0/3] iplink_can: fix checkpatch.pl warnings patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250922-astute-impressive-skink-36e51a-mkl@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=dsahern@gmail.com \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mailhol@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=socketcan@hartkopp.net \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).