From: Stephen Hemminger <stephen@networkplumber.org>
To: Vincent Mailhol <mailhol@kernel.org>
Cc: netdev@vger.kernel.org, David Ahern <dsahern@gmail.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Oliver Hartkopp <socketcan@hartkopp.net>,
linux-kernel@vger.kernel.org, linux-can@vger.kernel.org
Subject: Re: [PATCH iproute2-next 3/3] iplink_can: factorise the calls to usage()
Date: Mon, 22 Sep 2025 15:09:20 -0700 [thread overview]
Message-ID: <20250922150920.78b95c44@hermes.local> (raw)
In-Reply-To: <20250921-iplink_can-checkpatch-fixes-v1-3-1ddab98560cd@kernel.org>
On Sun, 21 Sep 2025 16:32:32 +0900
Vincent Mailhol <mailhol@kernel.org> wrote:
> usage() is called either if the user passes the "help" argument or passes
> an invalid argument.
>
> Factorise those two cases together.
>
> This silences below checkpatch.pl warning:
>
> WARNING: else is not generally useful after a break or return
> #274: FILE: ip/iplink_can.c:274:
> + return -1;
> + } else {
>
> Signed-off-by: Vincent Mailhol <mailhol@kernel.org>
> ---
Not accepting most checkpatch stuff in iproute2.
Better to not have code churn
next prev parent reply other threads:[~2025-09-22 22:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-21 7:32 [PATCH iproute2-next 0/3] iplink_can: fix checkpatch.pl warnings Vincent Mailhol
2025-09-21 7:32 ` [PATCH iproute2-next 1/3] iplink_can: fix coding style for pointer format Vincent Mailhol
2025-09-22 22:10 ` Stephen Hemminger
2025-09-23 2:07 ` Vincent Mailhol
2025-09-21 7:32 ` [PATCH iproute2-next 2/3] iplink_can: fix SPDX-License-Identifier tag format Vincent Mailhol
2025-09-22 22:08 ` Stephen Hemminger
2025-09-21 7:32 ` [PATCH iproute2-next 3/3] iplink_can: factorise the calls to usage() Vincent Mailhol
2025-09-22 22:09 ` Stephen Hemminger [this message]
2025-09-22 8:42 ` [PATCH iproute2-next 0/3] iplink_can: fix checkpatch.pl warnings Marc Kleine-Budde
2025-09-25 16:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250922150920.78b95c44@hermes.local \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).