From: Vincent Mailhol <mailhol@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
Oliver Hartkopp <socketcan@hartkopp.net>
Cc: "Vincent Mailhol" <mailhol@kernel.org>,
"Stéphane Grosjean" <stephane.grosjean@hms-networks.com>,
"Robert Nawrath" <mbro1689@gmail.com>,
"Minh Le" <minh.le.aj@renesas.com>,
"Duy Nguyen" <duy.nguyen.rh@renesas.com>,
linux-can@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 09/20] can: netlink: make can_tdc_changelink() FD agnostic
Date: Tue, 23 Sep 2025 14:39:44 +0900 [thread overview]
Message-ID: <20250923-canxl-netlink-prep-v3-9-87a7684333f3@kernel.org> (raw)
In-Reply-To: <20250923-canxl-netlink-prep-v3-0-87a7684333f3@kernel.org>
can_tdc_changelink() needs to access can_priv->fd making it
specific to CAN FD. Change the function parameter from struct can_priv
to struct data_bittiming_params. This way, the function becomes CAN FD
agnostic and can be reused later on for the CAN XL TDC.
Signed-off-by: Vincent Mailhol <mailhol@kernel.org>
---
drivers/net/can/dev/netlink.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/net/can/dev/netlink.c b/drivers/net/can/dev/netlink.c
index 17ed52d238e3a17e946116a94c7c5f503e184c3d..abff7b84fdce9641e1a5338ec6cef992774b0ec0 100644
--- a/drivers/net/can/dev/netlink.c
+++ b/drivers/net/can/dev/netlink.c
@@ -172,12 +172,13 @@ static int can_validate(struct nlattr *tb[], struct nlattr *data[],
return 0;
}
-static int can_tdc_changelink(struct can_priv *priv, const struct nlattr *nla,
+static int can_tdc_changelink(struct data_bittiming_params *dbt_params,
+ const struct nlattr *nla,
struct netlink_ext_ack *extack)
{
struct nlattr *tb_tdc[IFLA_CAN_TDC_MAX + 1];
struct can_tdc tdc = { 0 };
- const struct can_tdc_const *tdc_const = priv->fd.tdc_const;
+ const struct can_tdc_const *tdc_const = dbt_params->tdc_const;
int err;
if (!tdc_const)
@@ -215,7 +216,7 @@ static int can_tdc_changelink(struct can_priv *priv, const struct nlattr *nla,
tdc.tdcf = tdcf;
}
- priv->fd.tdc = tdc;
+ dbt_params->tdc = tdc;
return 0;
}
@@ -382,8 +383,8 @@ static int can_changelink(struct net_device *dev, struct nlattr *tb[],
memset(&priv->fd.tdc, 0, sizeof(priv->fd.tdc));
if (data[IFLA_CAN_TDC]) {
/* TDC parameters are provided: use them */
- err = can_tdc_changelink(priv, data[IFLA_CAN_TDC],
- extack);
+ err = can_tdc_changelink(&priv->fd,
+ data[IFLA_CAN_TDC], extack);
if (err) {
priv->ctrlmode &= ~CAN_CTRLMODE_FD_TDC_MASK;
return err;
--
2.49.1
next prev parent reply other threads:[~2025-09-23 5:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 5:39 [PATCH v3 00/20] can: netlink: preparation before introduction of CAN XL step 3/3 Vincent Mailhol
2025-09-23 5:39 ` [PATCH v3 01/20] can: dev: move struct data_bittiming_params to linux/can/bittiming.h Vincent Mailhol
2025-09-23 5:39 ` [PATCH v3 02/20] can: dev: make can_get_relative_tdco() FD agnostic and move it to bittiming.h Vincent Mailhol
2025-09-23 5:39 ` [PATCH v3 03/20] can: netlink: document which symbols are FD specific Vincent Mailhol
2025-09-23 5:39 ` [PATCH v3 04/20] can: netlink: refactor can_validate_bittiming() Vincent Mailhol
2025-09-23 5:39 ` [PATCH v3 05/20] can: netlink: add can_validate_tdc() Vincent Mailhol
2025-09-23 5:39 ` [PATCH v3 06/20] can: netlink: add can_validate_databittiming() Vincent Mailhol
2025-09-23 5:39 ` [PATCH v3 07/20] can: netlink: refactor CAN_CTRLMODE_TDC_{AUTO,MANUAL} flag reset logic Vincent Mailhol
2025-09-23 5:39 ` [PATCH v3 08/20] can: netlink: remove useless check in can_tdc_changelink() Vincent Mailhol
2025-09-23 5:39 ` Vincent Mailhol [this message]
2025-09-23 5:39 ` [PATCH v3 10/20] can: netlink: add can_dtb_changelink() Vincent Mailhol
2025-09-23 5:39 ` [PATCH v3 11/20] can: netlink: add can_ctrlmode_changelink() Vincent Mailhol
2025-09-23 5:39 ` [PATCH v3 12/20] can: netlink: make can_tdc_get_size() FD agnostic Vincent Mailhol
2025-09-23 5:39 ` [PATCH v3 13/20] can: netlink: add can_data_bittiming_get_size() Vincent Mailhol
2025-09-23 5:39 ` [PATCH v3 14/20] can: netlink: add can_bittiming_fill_info() Vincent Mailhol
2025-09-23 5:39 ` [PATCH v3 15/20] can: netlink: add can_bittiming_const_fill_info() Vincent Mailhol
2025-09-23 5:39 ` [PATCH v3 16/20] can: netlink: add can_bitrate_const_fill_info() Vincent Mailhol
2025-09-23 5:39 ` [PATCH v3 17/20] can: netlink: make can_tdc_fill_info() FD agnostic Vincent Mailhol
2025-09-23 5:39 ` [PATCH v3 18/20] can: calc_bittiming: make can_calc_tdco() " Vincent Mailhol
2025-09-23 5:39 ` [PATCH v3 19/20] can: dev: add can_get_ctrlmode_str() Vincent Mailhol
2025-09-23 5:39 ` [PATCH v3 20/20] can: netlink: add userland error messages Vincent Mailhol
2025-09-23 6:02 ` [PATCH v3 00/20] can: netlink: preparation before introduction of CAN XL step 3/3 Vincent Mailhol
2025-09-23 17:08 ` Konstantin Ryabitsev
2025-09-23 17:54 ` Vincent Mailhol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250923-canxl-netlink-prep-v3-9-87a7684333f3@kernel.org \
--to=mailhol@kernel.org \
--cc=duy.nguyen.rh@renesas.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbro1689@gmail.com \
--cc=minh.le.aj@renesas.com \
--cc=mkl@pengutronix.de \
--cc=socketcan@hartkopp.net \
--cc=stephane.grosjean@hms-networks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).