linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vincent Mailhol <mailhol@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
	 Oliver Hartkopp <socketcan@hartkopp.net>
Cc: "Vincent Mailhol" <mailhol@kernel.org>,
	"Stéphane Grosjean" <stephane.grosjean@hms-networks.com>,
	"Robert Nawrath" <mbro1689@gmail.com>,
	"Minh Le" <minh.le.aj@renesas.com>,
	"Duy Nguyen" <duy.nguyen.rh@renesas.com>,
	linux-can@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 01/20] can: dev: move struct data_bittiming_params to linux/can/bittiming.h
Date: Tue, 23 Sep 2025 15:58:26 +0900	[thread overview]
Message-ID: <20250923-canxl-netlink-prep-v4-1-e720d28f66fe@kernel.org> (raw)
In-Reply-To: <20250923-canxl-netlink-prep-v4-0-e720d28f66fe@kernel.org>

In commit b803c4a4f788 ("can: dev: add struct data_bittiming_params to
group FD parameters"), struct data_bittiming_params was put into
linux/can/dev.h.

This structure being a collection of bittiming parameters, on second
thought, bittiming.h is actually a better location. This way, users of
struct data_bittiming_params will not have to forcefully include
linux/can/dev.h thus removing some complexity and reducing the risk of
circular dependencies in headers.

Move struct data_bittiming_params from linux/can/dev.h to
linux/can/bittiming.h.

Signed-off-by: Vincent Mailhol <mailhol@kernel.org>
---
 include/linux/can/bittiming.h | 11 +++++++++++
 include/linux/can/dev.h       | 11 -----------
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/include/linux/can/bittiming.h b/include/linux/can/bittiming.h
index 5dfdbb63b1d54f3dc02170b10b73dbb9c2242851..6572ec1712ca2df8db7fe1453ae5a4d5699712b1 100644
--- a/include/linux/can/bittiming.h
+++ b/include/linux/can/bittiming.h
@@ -114,6 +114,17 @@ struct can_tdc_const {
 	u32 tdcf_max;
 };
 
+struct data_bittiming_params {
+	const struct can_bittiming_const *data_bittiming_const;
+	struct can_bittiming data_bittiming;
+	const struct can_tdc_const *tdc_const;
+	struct can_tdc tdc;
+	const u32 *data_bitrate_const;
+	unsigned int data_bitrate_const_cnt;
+	int (*do_set_data_bittiming)(struct net_device *dev);
+	int (*do_get_auto_tdcv)(const struct net_device *dev, u32 *tdcv);
+};
+
 #ifdef CONFIG_CAN_CALC_BITTIMING
 int can_calc_bittiming(const struct net_device *dev, struct can_bittiming *bt,
 		       const struct can_bittiming_const *btc, struct netlink_ext_ack *extack);
diff --git a/include/linux/can/dev.h b/include/linux/can/dev.h
index 3354f70ed2c684d7d482549560d4cb5838cbebd5..c2fe956ab7761f45a87e77131bb57e9d5d51dd7f 100644
--- a/include/linux/can/dev.h
+++ b/include/linux/can/dev.h
@@ -38,17 +38,6 @@ enum can_termination_gpio {
 	CAN_TERMINATION_GPIO_MAX,
 };
 
-struct data_bittiming_params {
-	const struct can_bittiming_const *data_bittiming_const;
-	struct can_bittiming data_bittiming;
-	const struct can_tdc_const *tdc_const;
-	struct can_tdc tdc;
-	const u32 *data_bitrate_const;
-	unsigned int data_bitrate_const_cnt;
-	int (*do_set_data_bittiming)(struct net_device *dev);
-	int (*do_get_auto_tdcv)(const struct net_device *dev, u32 *tdcv);
-};
-
 /*
  * CAN common private data
  */

-- 
2.49.1


  reply	other threads:[~2025-09-23  6:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-23  6:58 [PATCH v4 00/20] can: netlink: preparation before introduction of CAN XL step 3/3 Vincent Mailhol
2025-09-23  6:58 ` Vincent Mailhol [this message]
2025-09-23  6:58 ` [PATCH v4 02/20] can: dev: make can_get_relative_tdco() FD agnostic and move it to bittiming.h Vincent Mailhol
2025-09-23  6:58 ` [PATCH v4 03/20] can: netlink: document which symbols are FD specific Vincent Mailhol
2025-09-23  6:58 ` [PATCH v4 04/20] can: netlink: refactor can_validate_bittiming() Vincent Mailhol
2025-09-23  6:58 ` [PATCH v4 05/20] can: netlink: add can_validate_tdc() Vincent Mailhol
2025-09-23  6:58 ` [PATCH v4 06/20] can: netlink: add can_validate_databittiming() Vincent Mailhol
2025-09-23  6:58 ` [PATCH v4 07/20] can: netlink: refactor CAN_CTRLMODE_TDC_{AUTO,MANUAL} flag reset logic Vincent Mailhol
2025-09-23  6:58 ` [PATCH v4 08/20] can: netlink: remove useless check in can_tdc_changelink() Vincent Mailhol
2025-09-23  6:58 ` [PATCH v4 09/20] can: netlink: make can_tdc_changelink() FD agnostic Vincent Mailhol
2025-09-23  6:58 ` [PATCH v4 10/20] can: netlink: add can_dtb_changelink() Vincent Mailhol
2025-09-23  6:58 ` [PATCH v4 11/20] can: netlink: add can_ctrlmode_changelink() Vincent Mailhol
2025-09-23  6:58 ` [PATCH v4 12/20] can: netlink: make can_tdc_get_size() FD agnostic Vincent Mailhol
2025-09-23  6:58 ` [PATCH v4 13/20] can: netlink: add can_data_bittiming_get_size() Vincent Mailhol
2025-09-23  6:58 ` [PATCH v4 14/20] can: netlink: add can_bittiming_fill_info() Vincent Mailhol
2025-09-23  6:58 ` [PATCH v4 15/20] can: netlink: add can_bittiming_const_fill_info() Vincent Mailhol
2025-09-23  6:58 ` [PATCH v4 16/20] can: netlink: add can_bitrate_const_fill_info() Vincent Mailhol
2025-09-23  6:58 ` [PATCH v4 17/20] can: netlink: make can_tdc_fill_info() FD agnostic Vincent Mailhol
2025-09-23  6:58 ` [PATCH v4 18/20] can: calc_bittiming: make can_calc_tdco() " Vincent Mailhol
2025-09-23  6:58 ` [PATCH v4 19/20] can: dev: add can_get_ctrlmode_str() Vincent Mailhol
2025-09-23  6:58 ` [PATCH v4 20/20] can: netlink: add userland error messages Vincent Mailhol
2025-09-23  9:09 ` [PATCH v4 00/20] can: netlink: preparation before introduction of CAN XL step 3/3 Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250923-canxl-netlink-prep-v4-1-e720d28f66fe@kernel.org \
    --to=mailhol@kernel.org \
    --cc=duy.nguyen.rh@renesas.com \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbro1689@gmail.com \
    --cc=minh.le.aj@renesas.com \
    --cc=mkl@pengutronix.de \
    --cc=socketcan@hartkopp.net \
    --cc=stephane.grosjean@hms-networks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).