From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
Vincent Mailhol <mailhol@kernel.org>,
Patrik Flykt <patrik.flykt@linux.intel.com>,
Dong Aisheng <b29396@freescale.com>,
Varka Bhadram <varkabhadram@gmail.com>,
Wu Bo <wubo.oduw@gmail.com>,
Markus Schneider-Pargmann <msp@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-can@vger.kernel.org, kernel@pengutronix.de,
Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [PATCH v3 0/6] can: m_can: fix pm_runtime and CAN state handling
Date: Tue, 23 Sep 2025 11:17:13 +0200 [thread overview]
Message-ID: <20250923-m_can-fix-state-handling-v3-0-06d8baccadbf@pengutronix.de> (raw)
The first patch fixes a pm_runtime imbalance in the m_can_platform
driver.
The rest of this series fixes the CAN state handling in the m_can
driver:
- add the missing state transition from "Error Warning" back to "Error
Active" (patch 2)
- address the fact that in some SoCs (observed on the STM32MP15) the
M_CAN IP core keeps the CAN state and CAN error counters over an
internal reset cycle. Set the correct CAN state during ifup and
system resume (patches 3+4)
- add support for optional shared external reset, to properly reset
the IP core (patches 5+6)
The update of the DT binding for the reset property is upstream:
https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git/commit/?h=stm32-next&id=cfd856da6cf561f7e1dc6b16f3453814cde1058e
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
Changes in v3:
- 2: drop patch
- 3: add Markus's R-b
- 4: add Markus's R-b
- 7: add dev_err_probe() to error path (thanks Markus)
- Link to v2: https://patch.msgid.link/20250909-m_can-fix-state-handling-v2-0-af9fa240b68a@pengutronix.de
Changes in v2:
- cover: added link to DT bindings update (thanks Philipp)
- 1: add Markus's R-b
- 2: always mask active interrupts (thanks Markus)
- 3: remove not needed comments (thanks Markus)
- 3: rename m_can_can_state_get_by_psr() -> m_can_state_get_by_psr() (thanks Markus)
- 3: read PSR inside m_can_state_get_by_psr() (thanks Markus)
- 5: add Markus's R-b
- 7: fix typo (thanks Philipp)
- 7: rename struct m_can_classdev::rsts -> rst (thanks Philipp)
- Link to v1: https://patch.msgid.link/20250812-m_can-fix-state-handling-v1-0-b739e06c0a3b@pengutronix.de
---
Marc Kleine-Budde (6):
can: m_can: m_can_plat_remove(): add missing pm_runtime_disable()
can: m_can: m_can_handle_state_errors(): fix CAN state transition to Error Active
can: m_can: m_can_chip_config(): bring up interface in correct state
can: m_can: fix CAN state in system PM
can: m_can: m_can_get_berr_counter(): don't wake up controller if interface is down
can: m_can: add optional support for reset
drivers/net/can/m_can/m_can.c | 95 +++++++++++++++++++++++-----------
drivers/net/can/m_can/m_can.h | 1 +
drivers/net/can/m_can/m_can_platform.c | 2 +-
3 files changed, 67 insertions(+), 31 deletions(-)
---
base-commit: b65678cacc030efd53c38c089fb9b741a2ee34c8
change-id: 20250811-m_can-fix-state-handling-0ba4bda6cb8e
Best regards,
--
Marc Kleine-Budde <mkl@pengutronix.de>
next reply other threads:[~2025-09-23 9:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 9:17 Marc Kleine-Budde [this message]
2025-09-23 9:17 ` [PATCH v3 1/6] can: m_can: m_can_plat_remove(): add missing pm_runtime_disable() Marc Kleine-Budde
2025-09-23 9:17 ` [PATCH v3 2/6] can: m_can: m_can_handle_state_errors(): fix CAN state transition to Error Active Marc Kleine-Budde
2025-09-23 9:17 ` [PATCH v3 3/6] can: m_can: m_can_chip_config(): bring up interface in correct state Marc Kleine-Budde
2025-09-23 9:17 ` [PATCH v3 4/6] can: m_can: fix CAN state in system PM Marc Kleine-Budde
2025-09-23 9:17 ` [PATCH v3 5/6] can: m_can: m_can_get_berr_counter(): don't wake up controller if interface is down Marc Kleine-Budde
2025-09-23 12:09 ` Markus Schneider-Pargmann
2025-09-23 9:17 ` [PATCH v3 6/6] can: m_can: add optional support for reset Marc Kleine-Budde
2025-09-23 12:06 ` Markus Schneider-Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250923-m_can-fix-state-handling-v3-0-06d8baccadbf@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=b29396@freescale.com \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=msp@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=patrik.flykt@linux.intel.com \
--cc=rcsekar@samsung.com \
--cc=varkabhadram@gmail.com \
--cc=wubo.oduw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).