From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Celeste Liu <uwu@coelacanthus.name>
Cc: Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Maximilian Schneider <max@schneidersoft.net>,
Henrik Brix Andersen <henrik@brixandersen.dk>,
Wolfgang Grandegger <wg@grandegger.com>,
Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
Runcheng Lu <runcheng.lu@hpmicro.com>,
stable@vger.kernel.org, Vincent Mailhol <mailhol@kernel.org>
Subject: Re: [PATCH v5] net/can/gs_usb: increase max interface to U8_MAX
Date: Tue, 30 Sep 2025 17:40:44 +0200 [thread overview]
Message-ID: <20250930-translucent-tested-sheep-347fb2-mkl@pengutronix.de> (raw)
In-Reply-To: <20250930-gs-usb-max-if-v5-1-863330bf6666@coelacanthus.name>
[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]
On 30.09.2025 19:34:28, Celeste Liu wrote:
> This issue was found by Runcheng Lu when develop HSCanT USB to CAN FD
> converter[1]. The original developers may have only 3 interfaces device to
> test so they write 3 here and wait for future change.
>
> During the HSCanT development, we actually used 4 interfaces, so the
> limitation of 3 is not enough now. But just increase one is not
> future-proofed. Since the channel index type in gs_host_frame is u8, just
> make canch[] become a flexible array with a u8 index, so it naturally
> constraint by U8_MAX and avoid statically allocate 256 pointer for
> every gs_usb device.
>
> [1]: https://github.com/cherry-embedded/HSCanT-hardware
>
> Fixes: d08e973a77d1 ("can: gs_usb: Added support for the GS_USB CAN devices")
> Reported-by: Runcheng Lu <runcheng.lu@hpmicro.com>
> Cc: stable@vger.kernel.org
> Reviewed-by: Vincent Mailhol <mailhol@kernel.org>
> Signed-off-by: Celeste Liu <uwu@coelacanthus.name>
Applied to linux-can.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2025-09-30 15:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 11:34 [PATCH v5] net/can/gs_usb: increase max interface to U8_MAX Celeste Liu
2025-09-30 15:40 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250930-translucent-tested-sheep-347fb2-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=gustavoars@kernel.org \
--cc=henrik@brixandersen.dk \
--cc=kees@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mailhol@kernel.org \
--cc=max@schneidersoft.net \
--cc=runcheng.lu@hpmicro.com \
--cc=stable@vger.kernel.org \
--cc=uwu@coelacanthus.name \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).