From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F3A72F12DB for ; Fri, 17 Oct 2025 15:00:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760713237; cv=none; b=LQFZg7qrMMo0+dLznfU0wfTyTL1JLKvDlCSOIFQtOPUgaXV34LoVdZ4K+/2Xq2IGX3Lesy15dLE8tkZrymbfjItgMroyY0lCS6xyxfm4Hwo86mjxOyut65y/gsUpsQutNS+aKW0pwBt5xIcNwUYAsWuBZEyqDkk/dTO2hUHkkl0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760713237; c=relaxed/simple; bh=do8Wgxd/SePEpeQkAsWrN+ulD9bfSWdKS4T6ApEwOUo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fWtGbQPsVbMqhOl53P3/cn+JlVDKQ/erVq60Edk5MR63dPNKZvZCNDED9Es2DmEhZU57J3AgcvKxglaXtc3zAmuvGofUfpUjt3WM7bxjj+cSrFFYCoYDy+6Byr1BnOdvE2e0AlljnJ4jFgyS+AiXmI+he4MAgDM2gD91UF1h9tY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1v9lwJ-00028F-Pd; Fri, 17 Oct 2025 17:00:19 +0200 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v9lwJ-0044jZ-0N; Fri, 17 Oct 2025 17:00:19 +0200 Received: from hardanger.blackshift.org (p54b152ce.dip0.t-ipconnect.de [84.177.82.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id C0D6A48928B; Fri, 17 Oct 2025 15:00:18 +0000 (UTC) From: Marc Kleine-Budde Date: Fri, 17 Oct 2025 17:00:01 +0200 Subject: [PATCH can 3/3] can: rockchip-canfd: rkcanfd_start_xmit(): use can_dev_dropped_skb() instead of can_dropped_invalid_skb() Precedence: bulk X-Mailing-List: linux-can@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251017-fix-skb-drop-check-v1-3-556665793fa4@pengutronix.de> References: <20251017-fix-skb-drop-check-v1-0-556665793fa4@pengutronix.de> In-Reply-To: <20251017-fix-skb-drop-check-v1-0-556665793fa4@pengutronix.de> To: Dario Binacchi , Vincent Mailhol , Oliver Hartkopp , =?utf-8?q?Stefan_M=C3=A4tje?= , socketcan@esd.eu, Heiko Stuebner Cc: kernel@pengutronix.de, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Marc Kleine-Budde X-Mailer: b4 0.15-dev-2196b X-Developer-Signature: v=1; a=openpgp-sha256; l=1226; i=mkl@pengutronix.de; h=from:subject:message-id; bh=do8Wgxd/SePEpeQkAsWrN+ulD9bfSWdKS4T6ApEwOUo=; b=owEBbQGS/pANAwAKAQx0Zd/5kJGcAcsmYgBo8loAzlnTFkscuFLWoJevL9wZCAxD/XhVtKVyT 9cJR3/TvYyJATMEAAEKAB0WIQSf+wzYr2eoX/wVbPMMdGXf+ZCRnAUCaPJaAAAKCRAMdGXf+ZCR nFH3B/9qk6/QRm+Ue+6x+T4+qzokomC+tS3HS7duJg/kTEO0kLDl0XBKzZ8c3pRByh+d6fNMbHc RYV3oGCG6S6P5FokWoSfxTxb2S0KdrpooyWsiOagVv2RDy9qWlzr9GG+IFqF4tXB4InOKq+rcts MfayrVhn1ONZxd+WkCIxVEgZ7EsiJfEz57jFqJ2/S7xH04URxxmSwYj5WwJ0tMSAwHHn6X3vJ1v OLuZwfKs4GFwihpejvX5cx0dKmQOZZveBwM+UJ8bmFfOYJ0+X3FQpwM9poSR7HUvn1WZ7ReuPFa l+dtdTeUuQmTFx7LqiYzUSPxju6tTkf/ciJFQSWKfgkN4z/2 X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-can@vger.kernel.org In addition to can_dropped_invalid_skb(), the helper function can_dev_dropped_skb() checks whether the device is in listen-only mode and discards the skb accordingly. Replace can_dropped_invalid_skb() by can_dev_dropped_skb() to also drop skbs in for listen-only mode. Reported-by: Marc Kleine-Budde Closes: https://lore.kernel.org/all/20251017-bizarre-enchanted-quokka-f3c704-mkl@pengutronix.de/ Fixes: ff60bfbaf67f ("can: rockchip_canfd: add driver for Rockchip CAN-FD controller") Signed-off-by: Marc Kleine-Budde --- drivers/net/can/rockchip/rockchip_canfd-tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/rockchip/rockchip_canfd-tx.c b/drivers/net/can/rockchip/rockchip_canfd-tx.c index 865a15e033a9..12200dcfd338 100644 --- a/drivers/net/can/rockchip/rockchip_canfd-tx.c +++ b/drivers/net/can/rockchip/rockchip_canfd-tx.c @@ -72,7 +72,7 @@ netdev_tx_t rkcanfd_start_xmit(struct sk_buff *skb, struct net_device *ndev) int err; u8 i; - if (can_dropped_invalid_skb(ndev, skb)) + if (can_dev_dropped_skb(ndev, skb)) return NETDEV_TX_OK; if (!netif_subqueue_maybe_stop(priv->ndev, 0, -- 2.51.0