From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 549743803FE for ; Tue, 10 Feb 2026 14:50:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770735055; cv=none; b=DkucjLWEh2RwWLG7a7EjTKvP0RmbOq+VyDMi5rHsWjn9VLtJviacGdu5BZFEYrQwjZVVj3SFM6YNN2nOfpiGXC7n+DR1R24pAppS9VSpI6MEhFrWPVbSSUA4Tio7yvEikJD3W+dIH88nBAH3DNa/N8i0s7xRSiCD8A4A9BZdqP8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770735055; c=relaxed/simple; bh=9c1S3H8X8QsSP4kraC55PPtdYkNUt5JhUIat0IXzrjw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bR9Fl1CEokSP00InUh2aDsKG77fArBkvGmCgfwtjbtLrFQEv5KVw7noCgibcK1qIy9Xu4D9u5vOeq2MwHgi7QQy18g/ZQQKFXZKsqrHN8jyrf8sZyerLaSDKTP1XwViUQZzk/cy/VTLeLR4AMoRbH9EaLqeJp9fgzxo18bflTzE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b=ZZUcFHDM; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b=ZZUcFHDM; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="ZZUcFHDM"; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="ZZUcFHDM" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 72C7F3E6FE; Tue, 10 Feb 2026 14:50:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1770735052; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=qeIKpw/9UD/Nq07hsfUEx80wf+G0vaHtEGXpJB/mjXQ=; b=ZZUcFHDM/OK9SAoz1tTexb1rQpEIVo94rtJkXbLlKDScb6963HpR3Hy7iUfoR2HBTWFSVK dJg8sTH6+7FM5TRgV1Xy39LveD9lo1P9Piaw96EgH+nNSteagATpnj6YWbHs/NA/FgetLt EANWbOfSg6lT31tIdbKUm2iFJkclmdc= Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1770735052; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=qeIKpw/9UD/Nq07hsfUEx80wf+G0vaHtEGXpJB/mjXQ=; b=ZZUcFHDM/OK9SAoz1tTexb1rQpEIVo94rtJkXbLlKDScb6963HpR3Hy7iUfoR2HBTWFSVK dJg8sTH6+7FM5TRgV1Xy39LveD9lo1P9Piaw96EgH+nNSteagATpnj6YWbHs/NA/FgetLt EANWbOfSg6lT31tIdbKUm2iFJkclmdc= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 39D533EA62; Tue, 10 Feb 2026 14:50:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id YQlVDMxFi2kMXgAAD6G6ig (envelope-from ); Tue, 10 Feb 2026 14:50:52 +0000 From: Oliver Neukum To: mailhol@kernel.org, mkl@pengutronix.de, linux-can@vger.kernel.org Cc: Oliver Neukum Subject: [PATCH] net: can: etas_es58x: full cleanup in the error case Date: Tue, 10 Feb 2026 15:50:49 +0100 Message-ID: <20260210145049.40995-1-oneukum@suse.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-can@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.80 X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:mid,suse.com:email,imap1.dmz-prg2.suse.org:helo]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_ALL(0.00)[] X-Spam-Level: X-Spam-Flag: NO Memory allocation can fail in the middle. Hence the cleanup needs to be called in every case. Fixes: 8537257874e94 ("can: etas_es58x: add core support for ETAS ES58X CAN USB interfaces") Signed-off-by: Oliver Neukum --- drivers/net/can/usb/etas_es58x/es58x_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/usb/etas_es58x/es58x_core.c b/drivers/net/can/usb/etas_es58x/es58x_core.c index 2d248deb69dc..19fa51821a89 100644 --- a/drivers/net/can/usb/etas_es58x/es58x_core.c +++ b/drivers/net/can/usb/etas_es58x/es58x_core.c @@ -1783,8 +1783,9 @@ static int es58x_open(struct net_device *netdev) if (!es58x_dev->opened_channel_cnt) { ret = es58x_alloc_rx_urbs(es58x_dev); + /* can fail partially */ if (ret) - return ret; + goto free_urbs; ret = es58x_set_realtime_diff_ns(es58x_dev); if (ret) -- 2.53.0