From: Johan Hovold <johan@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol@kernel.org>
Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan@kernel.org>
Subject: [PATCH 1/2] can: kvaser_usb: leaf: refactor endpoint lookup
Date: Mon, 30 Mar 2026 12:18:16 +0200 [thread overview]
Message-ID: <20260330101817.1664787-2-johan@kernel.org> (raw)
In-Reply-To: <20260330101817.1664787-1-johan@kernel.org>
Use the common USB helper for looking up bulk and interrupt endpoints
instead of open coding.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
.../net/can/usb/kvaser_usb/kvaser_usb_leaf.c | 25 ++++++-------------
1 file changed, 8 insertions(+), 17 deletions(-)
diff --git a/drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c b/drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c
index fd191ec5738b..df737cfc5ea0 100644
--- a/drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c
+++ b/drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c
@@ -1957,27 +1957,18 @@ static int kvaser_usb_leaf_get_berr_counter(const struct net_device *netdev,
static int kvaser_usb_leaf_setup_endpoints(struct kvaser_usb *dev)
{
- const struct usb_host_interface *iface_desc;
- struct usb_endpoint_descriptor *endpoint;
- int i;
+ struct usb_host_interface *iface_desc;
+ int ret;
iface_desc = dev->intf->cur_altsetting;
- for (i = 0; i < iface_desc->desc.bNumEndpoints; ++i) {
- endpoint = &iface_desc->endpoint[i].desc;
-
- if (!dev->bulk_in && usb_endpoint_is_bulk_in(endpoint))
- dev->bulk_in = endpoint;
-
- if (!dev->bulk_out && usb_endpoint_is_bulk_out(endpoint))
- dev->bulk_out = endpoint;
+ /* use first bulk endpoint for in and out */
+ ret = usb_find_common_endpoints(iface_desc, &dev->bulk_in, &dev->bulk_out,
+ NULL, NULL);
+ if (ret)
+ return -ENODEV;
- /* use first bulk endpoint for in and out */
- if (dev->bulk_in && dev->bulk_out)
- return 0;
- }
-
- return -ENODEV;
+ return 0;
}
const struct kvaser_usb_dev_ops kvaser_usb_leaf_dev_ops = {
--
2.52.0
next prev parent reply other threads:[~2026-03-30 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 10:18 [PATCH 0/2] can: refactor USB endpoint lookups Johan Hovold
2026-03-30 10:18 ` Johan Hovold [this message]
2026-03-30 10:18 ` [PATCH 2/2] can: ucan: refactor endpoint lookup Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330101817.1664787-2-johan@kernel.org \
--to=johan@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox