From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 525A13FA5FF for ; Wed, 6 May 2026 12:54:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778072060; cv=none; b=bZ4zdk+UPH5b/uiF9nuX7ZDnLPtO1JwXkx2JiJ9nVI0KBSRUX4YFr2xNnHBgRnmP30foACRet5VQ7P6EQeAL+2pSGG1Fl2dDUuBZZCqLCI/BMh9KqnvjcXEpHtNbux+bJ//cCZPi0oK3A1Wl/nQFM6FkXEq0a6kSV7KLoC9tmyU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778072060; c=relaxed/simple; bh=nlaY5ptMktP4M6tZTPq32tLB5OIYy9nZEb0QhVLJvBI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L+FbWDddtv/zvHmNDftTnIf8Xxieyxx2dIsPPxKTIMdQUCP/rYNe+llbp0xdZT4KA5qfLgVZcqtmVEnFCHkENv8D44qtPVlQkKXIoMo8AM1DzoQtH1hQiSXy7I+o3WR5x7A7hYgSJvWiZKcLIZ2u1SJku7/WoTrDE8DmVClQ68U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1wKblZ-0007pf-9J; Wed, 06 May 2026 14:54:17 +0200 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wKblY-000kK5-1Z; Wed, 06 May 2026 14:54:16 +0200 Received: from pengutronix.de (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 99F1252F67F; Wed, 06 May 2026 12:54:16 +0000 (UTC) Date: Wed, 6 May 2026 14:54:16 +0200 From: Marc Kleine-Budde To: Alexander =?utf-8?B?SMO2bHps?= Cc: robin@protonic.nl, o.rempel@pengutronix.de, kernel@pengutronix.de, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] can: j1939: fix wrong rx timeout for CTS hold messages Message-ID: <20260506-crouching-precise-peccary-9bfd36-mkl@pengutronix.de> X-AI: stop_reason: "refusal" References: <20260421153152.87772-3-alexander.hoelzl@gmx.net> Precedence: bulk X-Mailing-List: linux-can@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hjgao4vnvhgi7zkb" Content-Disposition: inline In-Reply-To: <20260421153152.87772-3-alexander.hoelzl@gmx.net> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-can@vger.kernel.org --hjgao4vnvhgi7zkb Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] can: j1939: fix wrong rx timeout for CTS hold messages MIME-Version: 1.0 On 21.04.2026 17:31:54, Alexander H=C3=B6lzl wrote: > In J1939 segmented transport, a CTS message with data byte 2 set to zero = is interpreted as a hold message. > This instructs the transmitter of the segmented message to hold the conne= ction open but to delay sending. > According to the J1939-21 standard, section 5.10.2.4 the timeout T4 after= which an held open session is invalidated is > 1050 ms, not 550 as implemented currently. > The 550 ms are problematic if a device uses hold messages and assumes it = can wait for more than 550 ms before it has > to resend the hold message. > > This patch changes the T4 timeout used in the implementation from 550 ms = to 1050. > > Signed-off-by: Alexander H=C3=B6lzl Applied to linux-can + rewrap long lines in patch description, use imperative mood in last section. regards, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung N=C3=BCrnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 | --hjgao4vnvhgi7zkb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSl+MghEFFAdY3pYJLMOmT6rpmt0gUCafs59gAKCRDMOmT6rpmt 0qJYAQDzaTp76s89A1wA9HkKa489TqAQHcCmErsENmH5FvkEigEA9y4ipqJ5pq0r zCZy08Eh9KY/eH6KjSrpyWwPRKlKCQ0= =SfNi -----END PGP SIGNATURE----- --hjgao4vnvhgi7zkb--