Linux CAN drivers development
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: linux-atm-general@lists.sourceforge.net,
	linux-can@vger.kernel.org, linux-sctp@vger.kernel.org,
	netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
	herbert@gondor.apana.org.au, kuniyu@google.com,
	mkl@pengutronix.de, marcelo.leitner@gmail.com,
	ncardwell@google.com, socketcan@hartkopp.net, pabeni@redhat.com,
	courmisch@gmail.com, horms@kernel.org,
	steffen.klassert@secunet.com, willemdebruijn.kernel@gmail.com,
	lucien.xin@gmail.com, pmladek@suse.com,
	thomas.weissschuh@linutronix.de, kees@kernel.org
Subject: Re: [PATCH net-next v3] net: Replace %pK output with 0
Date: Fri, 14 Aug 2026 12:58:12 +0200	[thread overview]
Message-ID: <20260814105812.mwsdgu5m@linutronix.de> (raw)
In-Reply-To: <20260814015800.2837019-2-kuba@kernel.org>

On 2026-08-13 18:58:01 [-0700], Jakub Kicinski wrote:
> Hi Sebastian!
Hi Jakub,

> We have upgraded the slop...itifier since v2, it has more comments now...
> The one about %ps potentially leaking more rather than less looks legit?

It complains about %ps leaking the pointer if kallsym is switched off.
This isn't unique to can and I pointed this out to Kees. 
Oliver Hartkopp mentioned that he wanted to rework the can output.

I'm going to tell vsprintf to route the %ps output the same as %p for
!kallsym so this goes away. 

Depending on what you prefer we can keep it as it or I drop the can bits
and repost everything else as-it. And then address later the other
sashiko bits where the documentation mentions "location of socket in
memory".

Sebastian

  parent reply	other threads:[~2026-08-14 10:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-12 11:05 [PATCH net-next v3] net: Replace %pK output with 0 Sebastian Andrzej Siewior
2026-08-13 16:49 ` Kees Cook
2026-08-14  1:58 ` Jakub Kicinski
2026-08-14  9:15   ` Oliver Hartkopp
2026-08-14 10:58   ` Sebastian Andrzej Siewior [this message]
2026-08-14 13:55     ` Jakub Kicinski
2026-08-14 14:02       ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260814105812.mwsdgu5m@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=courmisch@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=horms@kernel.org \
    --cc=kees@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=linux-atm-general@lists.sourceforge.net \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=marcelo.leitner@gmail.com \
    --cc=mkl@pengutronix.de \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pmladek@suse.com \
    --cc=socketcan@hartkopp.net \
    --cc=steffen.klassert@secunet.com \
    --cc=thomas.weissschuh@linutronix.de \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox