Re: [PATCH v2 1/2] dt-bindings: can: m_can: add out band wakeup property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added custom device-specific property `out-band-wakeup` is missing a vendor prefix.
--

--- Patch [1]: [PATCH v2 1/2] dt-bindings: can: m_can: add out band wakeup property ---
commit 66d860c00379089f5518db1a67a453077a6864ea
Author: Kendall Willis <k-willis@ti.com>

dt-bindings: can: m_can: add out band wakeup property

This commit introduces the out-band-wakeup property to the m_can binding.
The property indicates if the CAN device is capable of waking up the system
even when its power domain is off.

> diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> index 2c9d37975bedd..b6cb945c225f1 100644
> --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> @@ -150,6 +150,11 @@ properties:
>      description:
>        List of phandles to system idle states in which mcan can wakeup the system.
>  
> +  out-band-wakeup:
> +    type: boolean
> +    description:
> +      Indicates CAN device is out-of-band wakeup capable.

[Severity: Low]
Should this device-specific property have a vendor prefix?

Since this property is not defined in a core common schema like dtschema
or can-controller.yaml, the Devicetree specification requires a vendor
prefix (such as ti,out-band-wakeup or bosch,out-band-wakeup) to prevent
property name collisions.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260820-temp-v2-0-dd3f8cacc15e@ti.com?part=1