From: yewentian395 <yewentian395@gmail.com>
To: Oliver Hartkopp <socketcan@hartkopp.net>,
Marc Kleine-Budde <mkl@pengutronix.de>
Cc: yewentian395 <yewentian395@gmail.com>,
linux-can@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: isotp: implement N_Ar timeout handling for FC transmission
Date: Wed, 26 Aug 2026 14:42:33 +0800 [thread overview]
Message-ID: <20260826064233.3248193-1-yewentian395@gmail.com> (raw)
In-Reply-To: <eb5e9618-3dbf-42cb-a635-752ff9fbcb99@hartkopp.net>
On 24.08.26 20:03, Oliver Hartkopp wrote:
> Nobody cares about so->frame_txtime and therefore I will not add any
> extra complexity to check for Ar/As timeouts which have no real world
> effect.
Thanks for the detailed explanation. The simplified model makes sense
given that no real-world user depends on strict N_Ar confirmation.
> Btw. while double-checking the code I have seen, that I was missing the
> addition of so->frame_txtime when starting the rxtimer above.
>
> I'll mention you with a Reported-by tag then.
Thank you, appreciated.
> Please also note that your patch would not apply on the latest upstream
> isotp code, which does not contain "*(u32 *)cf->data" anymore.
Noted. I was working against an older tree. Will rebase to latest
upstream for any future submissions.
Best regards,
wentian
next prev parent reply other threads:[~2026-08-26 6:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 12:53 [PATCH] qcan: isotp: implement N_Ar timeout handling for FC transmission yewentian395
2026-08-24 18:03 ` Oliver Hartkopp
2026-08-26 6:42 ` yewentian395 [this message]
2026-09-03 9:38 ` [PATCH] can: " yewentian395
2026-09-03 10:09 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260826064233.3248193-1-yewentian395@gmail.com \
--to=yewentian395@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox