Re: [PATCH] dt-bindings: net: can: convert ifi_canfd to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect use of `additionalProperties: false` with an `allOf` `$ref` breaks schema inheritance from `can-controller.yaml`.
--

commit fca96562b6a6638d3bb9a003f449b39969264629
Author: Quchaosheng <quchaosheng000406@163.com>

dt-bindings: net: can: convert ifi_canfd to DT schema

This commit converts the IFI CAN-FD controller binding from a free-form text
file to a YAML device tree schema and references the common
can-controller.yaml schema.

> diff --git a/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml b/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml
> new file mode 100644
> index 0000000000000..72f2b934c727b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml

[ ... ]

> +allOf:
> +  - $ref: can-controller.yaml#
> +
> +properties:
> +  compatible:
> +    const: ifi,canfd-1.0

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +additionalProperties: false

[Severity: Low]
Does using additionalProperties: false here break the schema inheritance from
can-controller.yaml?

Under JSON schema rules, additionalProperties: false only evaluates
properties explicitly defined in the local schema file. It ignores those
evaluated via an allOf reference, meaning any standard CAN properties
inherited from can-controller.yaml will cause device tree validation to fail.

Should this be unevaluatedProperties: false instead?

> +
> +examples:
> +  - |

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914013138.392969-1-quchaosheng000406@163.com?part=1