Re: [PATCH v2] dt-bindings: net: can: convert ifi_canfd to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incorrect use of `additionalProperties: false` when inheriting from a common schema via `$ref`, which improperly blocks inherited properties.
--

commit 471062b3f0e20cbfb084fbd8547c9d66999316e1
Author: Quchaosheng <quchaosheng000406@163.com>

dt-bindings: net: can: convert ifi_canfd to DT schema

Convert the IFI CAN-FD controller binding from free-form text to DT schema,
and reference the common can-controller.yaml schema.

> diff --git a/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml b/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml

[ ... ]

> +allOf:
> +  - $ref: can-controller.yaml#
> +
> +properties:

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +additionalProperties: false

[Severity: Medium]
Does using additionalProperties: false here conflict with the $ref to
can-controller.yaml#?

When referencing another schema via allOf, using additionalProperties: false
strictly forbids any properties not defined in the local file. This will cause
validation to fail if a device tree node includes standard CAN controller
properties like termination-gpios that are inherited from can-controller.yaml.

Should this be unevaluatedProperties: false instead, to allow the properties
defined in the referenced common schema?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914013745.394514-1-quchaosheng000406@163.com?part=1