From: sashiko-bot@kernel.org
To: Quchaosheng <quchaosheng000406@163.com>
Cc: linux-can@vger.kernel.org,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Oliver Hartkopp" <socketcan@hartkopp.net>,
"Vincent Mailhol" <mailhol@kernel.org>
Subject: Re: [PATCH] net: can: grcan: update the binding file reference in the driver comment
Date: Mon, 28 Sep 2026 11:31:06 +0000 [thread overview]
Message-ID: <20260928113107.290801F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260928112658.2119678-2-quchaosheng000406@163.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] doc: dangling reference to missing yaml binding file
--
commit f19b659d77f11a2ca8192b1defd0f0c8ae4f2108
Author: Quchaosheng <quchaosheng000406@163.com>
net: can: grcan: update the binding file reference in the driver comment
This commit updates the driver comments in grcan.c to point to a new
YAML binding file instead of the old text binding file.
> diff --git a/drivers/net/can/grcan.c b/drivers/net/can/grcan.c
> index ce12fa6df56d5..1b4944d1d06dd 100644
> --- a/drivers/net/can/grcan.c
> +++ b/drivers/net/can/grcan.c
> @@ -10,8 +10,8 @@
> * Full documentation of the GRCAN core can be found here:
> * http://www.gaisler.com/products/grlib/grip.pdf
> *
> - * See "Documentation/devicetree/bindings/net/can/grcan.txt" for information on
> - * open firmware properties.
> + * See "Documentation/devicetree/bindings/net/can/aeroflexgaisler,grcan.yaml"
> + * for information on open firmware properties.
[Severity: Medium]
Is the actual devicetree binding conversion missing from this patch?
The commit message states that grcan.txt is replaced by
aeroflexgaisler,grcan.yaml, but this patch only updates the comment in
drivers/net/can/grcan.c without adding the new YAML file or removing the
old text file.
Does this leave a dangling reference to a documentation file that does
not actually exist?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260928112658.2119678-2-quchaosheng000406@163.com?part=1
next prev parent reply other threads:[~2026-09-28 11:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 11:26 [PATCH] dt-bindings: net: can: convert grcan to DT schema Quchaosheng
2026-09-28 11:26 ` [PATCH] net: can: grcan: update the binding file reference in the driver comment Quchaosheng
2026-09-28 11:31 ` sashiko-bot [this message]
2026-09-28 18:18 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928113107.290801F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=o.rempel@pengutronix.de \
--cc=quchaosheng000406@163.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox