From: Jakub Kicinski <kuba@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Filippo Storniolo <fstornio@redhat.com>,
sashiko-reviews@lists.linux.dev,
Vincent Mailhol <mailhol@kernel.org>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Oliver Hartkopp <socketcan@hartkopp.net>,
linux-can@vger.kernel.org
Subject: Re: [PATCH can-next v3 3/3] can: add can diag interface
Date: Mon, 19 Oct 2026 13:45:00 -0700 [thread overview]
Message-ID: <20261019134500.58a76643@kernel.org> (raw)
In-Reply-To: <20261017-delectable-mackerel-of-calibration-1fad6d-mkl@pengutronix.de>
On Sat, 17 Oct 2026 12:10:21 +0200 Marc Kleine-Budde wrote:
> > I understand the concern, but as far as I can tell no other diag
> > handler implements this. Does it make sense to add it only here rather
> > than as a follow-up done uniformly across all the diag handlers?
> >
> > @Marc Kleine-Budde @Oliver Hartkopp what do you think about this?
> > If you think it could be worth adding this feature, I can do a respin.
>
> Let's ask Jakub (Cc'ed), who is the author of these 2 files:
>
> | Documentation/userspace-api/netlink/intro.rst
> | Documentation/core-api/netlink.rst
Sort of up to you, TBH. The AI loves to point this out,
but I think the fact most Netlink families don't handle
the inconsistency for 20 years almost proves that we're
fine without it?
next prev parent reply other threads:[~2026-10-19 20:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 14:12 [PATCH can-next v3 0/3] Introduce diag support for CAN Filippo Storniolo
2026-09-04 14:12 ` [PATCH can-next v3 1/3] af_can: ensure sk_protocol is always set on socket creation Filippo Storniolo
2026-10-20 15:26 ` Marc Kleine-Budde
2026-09-04 14:12 ` [PATCH can-next v3 2/3] af_can: store socket pointers in struct netns_can Filippo Storniolo
2026-09-04 14:12 ` [PATCH can-next v3 3/3] can: add can diag interface Filippo Storniolo
2026-09-04 14:26 ` sashiko-bot
2026-10-16 16:00 ` Filippo Storniolo
2026-10-17 10:10 ` Marc Kleine-Budde
2026-10-19 20:45 ` Jakub Kicinski [this message]
2026-10-20 12:27 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261019134500.58a76643@kernel.org \
--to=kuba@kernel.org \
--cc=fstornio@redhat.com \
--cc=linux-can@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=o.rempel@pengutronix.de \
--cc=sashiko-reviews@lists.linux.dev \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox