From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Stein Subject: Re: [PATCH] c_can: Add support for eg20t (pch_can) Date: Mon, 07 Apr 2014 14:24:17 +0200 Message-ID: <2082533.2A1719KrNC@ws-stein> References: <1396534451-9654-1-git-send-email-alexander.stein@systec-electronic.com> <534294F9.8030102@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from webbox1416.server-home.net ([77.236.96.61]:49841 "EHLO webbox1416.server-home.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754650AbaDGMZa (ORCPT ); Mon, 7 Apr 2014 08:25:30 -0400 In-Reply-To: <534294F9.8030102@pengutronix.de> Sender: linux-can-owner@vger.kernel.org List-ID: To: Marc Kleine-Budde Cc: Thomas Gleixner , Wolfgang Grandegger , linux-can@vger.kernel.org On Monday 07 April 2014 14:07:21, Marc Kleine-Budde wrote: > On 04/07/2014 02:06 PM, Thomas Gleixner wrote: > > On Mon, 7 Apr 2014, Alexander Stein wrote: > > > >> Hello Wolfgang, > >> > >> On Thursday 03 April 2014 20:41:24, Wolfgang Grandegger wrote: > >>> On 04/03/2014 04:14 PM, Alexander Stein wrote: > >>>> Signed-off-by: Alexander Stein > >>> > >>> Acked-by: Wolfgang Grandegger > >>> > >>> In my patch stack I have also th patch below. Could you please give it > >>> I try before I re-submit it. Thanks. > >> > >> With this patch the driver still works, at least MSI is working. The other problems still exist. > >> > > > > Which problems do still exist? > > IIRC: > Either potentially reordered frames or dropped frames. I'm currently trying to locate problem causes. Using your new set of patches on the tag linux-can-fixes-for-3.15-20140401 I lot of lost messages. Using bisect it seems that c0a9f4d39 "can: c_can: Reduce register access" introduced this problem on my hardware. Before that I only see switched messages occasionally. Best regards, Alexander