Linux CAN drivers development
 help / color / mirror / Atom feed
From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Matt Sealey <neko@bakuhatsu.net>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: imprecise external abort using the flexcan driver on i.MX6Q
Date: Mon, 30 Sep 2013 13:06:34 +0200	[thread overview]
Message-ID: <21065.23354.418805.871480@ipc1.ka-ro> (raw)
In-Reply-To: <5245E2C5.1030705@pengutronix.de>

Hi,

Marc Kleine-Budde writes:
> On 09/27/2013 07:24 PM, Matt Sealey wrote:
> > Marc - I don't think FLEXCAN has changed layout at all in these areas.
> > The hardware always worked this way..
> 
> All flexcan cores support the RX FIFO, the mx6 supports an additional
> mode for different acceptance filters.
> 
> > The only difference here  is that the i.MX53 is doing something weird
> > on the bus. The i.MX6Q is giving the absolutely correct BRESP for the
> > transfer to the peripheral (in effect, a "go away, this is my data"
> > failure, which the CPU turns into an imprecise abort since it no idea
> > which transaction it committed aeons ago caused it).
> > 
> > Writes to 0x90 to 0xDF while MCR[FEN] is set *should* cause a data
> > abort.. because it's not even a read-only region, it *should* be
> > totally inaccessible to the CPU.
> > 
> > The question I have is, when MCR[FEN] is set on i.MX53, does reading
> > from those reserved registers give anything but 0's or garbage? I'm
> > curious, that's all, it doesn't really matter ;)
> 
> The driver only read from message buffer 0, and uses buffer 8 for tx.
> The others are not accessed, unless in that chip start routine. We don't
> need this loop, it comes from the original driver. I think no one has
> ever noticed that bug, because all other CPUs have not complained.
> 
> The driver without the loop is working on mx6 and Lothar is testing it
> on mx53.
> 
I can confirm, that the driver still works on i.MX53 as before the
patch.
Is someone going to prepare a patch, or should I do it, as I was the
one who first brought up this issue?


Lothar Waßmann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info@karo-electronics.de
___________________________________________________________

  reply	other threads:[~2013-09-30 11:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <21060.15934.600859.167074@ipc1.ka-ro>
2013-09-26 15:42 ` imprecise external abort using the flexcan driver on i.MX6Q Marc Kleine-Budde
2013-09-26 15:54   ` Russell King - ARM Linux
2013-09-26 16:24     ` Santosh Shilimkar
2013-09-27  9:23       ` Lothar Waßmann
2013-09-27  9:43         ` Marc Kleine-Budde
2013-09-27 10:04           ` Lothar Waßmann
2013-09-27 10:14             ` Marc Kleine-Budde
2013-09-27 10:43               ` Lothar Waßmann
2013-09-26 19:04     ` Matt Sealey
2013-09-27  9:41       ` Lothar Waßmann
2013-09-27 17:24         ` Matt Sealey
2013-09-27 19:55           ` Marc Kleine-Budde
2013-09-30 11:06             ` Lothar Waßmann [this message]
2013-09-30 11:19               ` Marc Kleine-Budde
2013-09-30 11:37                 ` Lothar Waßmann
2013-09-30 11:39                   ` Marc Kleine-Budde
2013-09-27  8:59   ` Lothar Waßmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21065.23354.418805.871480@ipc1.ka-ro \
    --to=lw@karo-electronics.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mkl@pengutronix.de \
    --cc=neko@bakuhatsu.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox