Linux CAN drivers development
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: linux-can <linux-can@vger.kernel.org>,
	Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
Subject: Re: [PATCH] [RFC] can: fix msg_namelen values depending on CAN_REQUIRED_SIZE
Date: Wed, 24 Mar 2021 23:19:46 +0100 (CET)	[thread overview]
Message-ID: <224900630.112641.1616624386963.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20210324215442.44537-1-socketcan@hartkopp.net>

Oliver,

----- Ursprüngliche Mail -----
> @@ -808,10 +810,13 @@ static int raw_recvmsg(struct socket *sock, struct msghdr
> *msg, size_t size,
> 	int noblock;
> 
> 	noblock = flags & MSG_DONTWAIT;
> 	flags &= ~MSG_DONTWAIT;
> 
> +	if (msg->msg_name && msg->msg_namelen < RAW_MIN_NAMELEN)
> +		return -EINVAL;
> +

Like with Kurt's patch, my test fails here too because msg->msg_namelen is 0.
->msg_namelen is always 0 in the recvfrom() case.

Thanks,
//richard

  reply	other threads:[~2021-03-24 22:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-24 21:54 [PATCH] [RFC] can: fix msg_namelen values depending on CAN_REQUIRED_SIZE Oliver Hartkopp
2021-03-24 22:19 ` Richard Weinberger [this message]
2021-03-25  7:31   ` Oliver Hartkopp
2021-03-25  8:07     ` Kurt Van Dijck
2021-03-25  8:46       ` Kurt Van Dijck
2021-03-25  8:13 ` Kurt Van Dijck
2021-03-25  8:16   ` Oliver Hartkopp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=224900630.112641.1616624386963.JavaMail.zimbra@nod.at \
    --to=richard@nod.at \
    --cc=dev.kurt@vandijck-laurijssen.be \
    --cc=linux-can@vger.kernel.org \
    --cc=socketcan@hartkopp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox