From: Oliver Hartkopp <socketcan@hartkopp.net>
To: "Dr. David Alan Gilbert" <linux@treblig.org>, mkl@pengutronix.de
Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: of alloc_canxl_skb
Date: Fri, 13 Sep 2024 21:51:39 +0200 [thread overview]
Message-ID: <2540406e-8da3-4cb8-bd1a-30271dd6cc67@hartkopp.net> (raw)
In-Reply-To: <ZuRGRKU9bjgC52mD@gallifrey>
[-- Attachment #1: Type: text/plain, Size: 1385 bytes --]
Hi David,
On 13.09.24 16:03, Dr. David Alan Gilbert wrote:
> I'm doing some deadcode hunting and noticed that
>
> alloc_canxl_skb in drivers/net/can/dev/skb.c
>
> looks unused in the main kernel tree; is that expected?
> I see it was added back in 2022 by
> fb08cba12b52 ("can: canxl: update CAN infrastructure for CAN XL frames")
>
> I know almost exactly nothing about CAN, so I thought it best
> to ask!
I created some slides so that you can get an introduction to the
different CAN protocols CAN CC (aka Classical CAN), CAN FD and CAN XL:
https://github.com/linux-can/can-doc/tree/master/presentations
The introduction of the CAN XL support lead to some clean up and rework
also for the former alloc_can_skb() and alloc_canfd_skb() helpers.
The function is currently not in use in net/can/raw.c as it is only
needed when a CAN XL frame is received from read hardware. But the patch
also contains the definition of ETH_P_CANXL to already handle CAN XL
frames properly inside the Linux kernel and e.g. for WireShark 4.4.
There are currently some CAN XL IP cores in development (see attached
picture with an FPGA based IP core) and I am working on the kernel
infrastructure (e.g. bitrate configuration enhancements) on this board.
So alloc_canxl_skb() is already in use on my desk and there will be some
more stuff showing up soon ;-)
Best regards,
Oliver
[-- Attachment #2: DE1_SoC_FPGA_working_setup.jpg --]
[-- Type: image/jpeg, Size: 236146 bytes --]
next prev parent reply other threads:[~2024-09-13 19:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 14:03 of alloc_canxl_skb Dr. David Alan Gilbert
2024-09-13 19:51 ` Oliver Hartkopp [this message]
2024-09-13 20:05 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2540406e-8da3-4cb8-bd1a-30271dd6cc67@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox