Linux CAN drivers development
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@systec-electronic.com>
To: Wolfgang Grandegger <wg@grandegger.com>
Cc: Linux-CAN <linux-can@vger.kernel.org>,
	"bhupesh.sharma" <bhupesh.sharma@st.com>,
	Tomoya MORINAGA <tomoya.rohm@gmail.com>
Subject: Re: [RFC/PATCH] c_can: add driver for the PCH CAN controller
Date: Wed, 07 Mar 2012 08:31:40 +0100	[thread overview]
Message-ID: <2646233.lgKcZ8lAQj@ws-stein> (raw)
In-Reply-To: <4F44E640.8010708@grandegger.com>

Hello Wolfgang,

Am Mittwoch, 22. Februar 2012, 13:57:36 schrieb Wolfgang Grandegger:
> For maintenance reasons, this diver should replace the "pch_can" driver
> sooner than later as it uses the same CAN controller core. I named it
> "pch_pci". Maybe "pch_can" would be more appropriate (common). This
> patch is for 2.6.39, but likely it applies fine also to more recent
> versions of the Linux kernel.
> 
> Alexander, Tomoya, or anybody else, it would be nice if you could test
> this patch and give some feedback. Thanks.

Unfortunately this doesn't work, yet. I do get a can0 interface but I don't 
receive/send messages actually to the bus. I disabled pch_can in the kernel 
config and enabled CONFIG_CAN_C_CAN and CONFIG_CAN_C_CAN_PCH_PCI
All messages containging "can" (related to CAN) I get in dmesg are:
[    0.338083] CAN device driver interface                                                                                                                                                                           
[    0.339059] pch_pci 0000:02:0c.3: can0: Features changed: 0x00004804 -> 
0x00004004                                                                                                                                
[    0.827528] can: controller area network core (rev 20090105 abi 8)                                                                                                                                                
[    0.827646] can: raw protocol (rev 20090105)                                                                                                                                                                      
[    9.773280] pch_pci 0000:02:0c.3: can0: setting BTR=2504 BRPE=0000

I also noted that my system does noot reboot when using "reboot". This works 
fine when using pch_can.
Unfortunately I can't spend more time on testing this at the moment.

Best regards,
Alexander
-- 
Dipl.-Inf. Alexander Stein

SYS TEC electronic GmbH
August-Bebel-Str. 29
D-07973 Greiz

Tel: +49-3661-6279-0, Fax: +49-3661-6279-99
eMail:    Alexander.Stein@systec-electronic.com
Internet: http://www.systec-electronic.com

Managing Director: Dipl.-Phys. Siegmar Schmidt
Commercial registry: Amtsgericht Jena, HRB 205563

  parent reply	other threads:[~2012-03-07  7:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-22 12:57 [RFC/PATCH] c_can: add driver for the PCH CAN controller Wolfgang Grandegger
2012-02-23  0:13 ` Tomoya MORINAGA
2012-02-23  7:44   ` Wolfgang Grandegger
2012-02-23  8:08     ` Tomoya MORINAGA
2012-02-23  9:28       ` Wolfgang Grandegger
2012-02-23  8:27 ` Alexander Stein
2012-02-23  9:27   ` Wolfgang Grandegger
2012-02-23  9:48     ` Bhupesh SHARMA
2012-02-23  9:56       ` Alexander Stein
2012-02-23 10:00         ` Bhupesh SHARMA
2012-03-07  7:31 ` Alexander Stein [this message]
2012-03-12 17:53   ` Wolfgang Grandegger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2646233.lgKcZ8lAQj@ws-stein \
    --to=alexander.stein@systec-electronic.com \
    --cc=bhupesh.sharma@st.com \
    --cc=linux-can@vger.kernel.org \
    --cc=tomoya.rohm@gmail.com \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox