Linux CAN drivers development
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@systec-electronic.com>
To: linux-can@vger.kernel.org
Cc: Wolfgang Grandegger <wg@grandegger.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: [PATCH] c_can: Set reserved bit in IFx_MASK2 to set 1 on write
Date: Thu, 31 Jan 2013 12:18:01 +0100	[thread overview]
Message-ID: <2940059.0GSHQ8uFe8@ws-stein> (raw)
In-Reply-To: <1355389570-24180-1-git-send-email-alexander.stein@systec-electronic.com>

Ping

On Thursday 13 December 2012 10:06:10, Alexander Stein wrote:
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> ---
>  drivers/net/can/c_can/c_can.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c
> index 30646d6..2f9dedd2 100644
> --- a/drivers/net/can/c_can/c_can.c
> +++ b/drivers/net/can/c_can/c_can.c
> @@ -495,8 +495,12 @@ static void c_can_setup_receive_object(struct net_device *dev,
>  
>  	priv->write_reg(priv, C_CAN_IFACE(MASK1_REG, iface),
>  			IFX_WRITE_LOW_16BIT(mask));
> +
> +	/* According to C_CAN documentation, the reserved bit
> +	 * in IFx_MASK2 register is fixed 1
> +	 */
>  	priv->write_reg(priv, C_CAN_IFACE(MASK2_REG, iface),
> -			IFX_WRITE_HIGH_16BIT(mask));
> +			IFX_WRITE_HIGH_16BIT(mask) | BIT(13));
>  
>  	priv->write_reg(priv, C_CAN_IFACE(ARB1_REG, iface),
>  			IFX_WRITE_LOW_16BIT(id));
> 


  reply	other threads:[~2013-01-31 11:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-13  9:06 [PATCH] c_can: Set reserved bit in IFx_MASK2 to set 1 on write Alexander Stein
2013-01-31 11:18 ` Alexander Stein [this message]
2013-02-01  9:26   ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2940059.0GSHQ8uFe8@ws-stein \
    --to=alexander.stein@systec-electronic.com \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox