From: Alexander Stein <alexander.stein@systec-electronic.com>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH RFC] can: add Virtual CAN Tunnel driver (vxcan)
Date: Tue, 25 Apr 2017 10:14:17 +0200 [thread overview]
Message-ID: <2991941.MzkBZeoEfP@ws-stein> (raw)
In-Reply-To: <73a30dda-c0c6-a1f8-62d0-2cf4a193a7cc@hartkopp.net>
Hi Oliver,
On Tuesday 25 April 2017 08:28:11, Oliver Hartkopp wrote:
> On 04/25/2017 07:35 AM, Alexander Stein wrote:
> > On Monday 24 April 2017 22:12:37, Oliver Hartkopp wrote:
> >> +
> >> + netif_rx_ni(skb);
> >>
> > ^^^^^^^^^^
> >
> > Wouldn't this result in the known out-of-order problem on SMP systems?
>
> I don't think so.
> We're not dealing with irqs here that could reach different CPUs.
> This is all in softirq/userspace context.
> It's the same thing we have with the virtual CAN vcan.
That would be great. I don't know the complete code path but is it possible
that this xmit function is executed on different CPUs at the same time? e.g.
multiple sockets/threads writing a CAN frame.
Best regards,
Alexander
prev parent reply other threads:[~2017-04-25 8:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 20:12 [PATCH RFC] can: add Virtual CAN Tunnel driver (vxcan) Oliver Hartkopp
2017-04-24 20:12 ` [PATCH RFC] ip: link add vxcan support Oliver Hartkopp
2017-04-25 5:35 ` [PATCH RFC] can: add Virtual CAN Tunnel driver (vxcan) Alexander Stein
2017-04-25 6:28 ` Oliver Hartkopp
2017-04-25 8:14 ` Alexander Stein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2991941.MzkBZeoEfP@ws-stein \
--to=alexander.stein@systec-electronic.com \
--cc=linux-can@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox