From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D76830C16C; Thu, 2 Jul 2026 16:02:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783008159; cv=none; b=LMRCXuNHAC3X/6934MWOBRCcxZluzGdnCC7HHEi8WQU0xrGkiG0BN1OOf2yDFQHmk67TCnS86ciDzOoYkRI1zDcxNUd68yMP9TGkbI1OUVRCsK1RAyc0KRbQ914MV90f/gUGKK1qsI19gqR9ULW4+oeOggc2ULMrcwIInQKyejQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783008159; c=relaxed/simple; bh=Om1A/qUPAE+RvRc9QOCiGXLsDeJqGK2rZLRnc+C2LPU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=J/Rw/DGodzGCsy3VqeTK5NaSVGxAdAdPGXs3o44ECbr5KdVjxCFfz2JUy/7/elxNHTPqZn9nB7b3pLQR1QIEssAX1iB3/TXN3PMOukKPxlz3Zl6uNFAwWjp7kN1BQVp3OiA2mXNFHRqRSLsmDgnhzB9OsjNa3uyUYp+B4LKYt98= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=PRBdzR5F; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="PRBdzR5F" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=Om1A/qUPAE+RvRc9QOCiGXLsDeJqGK2rZLRnc+C2LPU=; b=PRBdzR5FrpwlcK69ZWsZm+uEdL nHKCecM0P3uNqXRCLMZ4e5saOl2fHva7y6aB+iizLxJ5rSNgl5cLsYRc0MP0jZAYG+N+CjwDIgtxL USbLfTdmx6Go5xHgm3Ipn5r7o5/8WqscetSYzfLsvbrSPKvFHmkkKDVmWzlG9b6RaTXch9YGUM1Q3 Ur2Z4NKK4n23iEY5JG53LPPskGXXTH1TmsI9rZHpC69Dlef40qlEKq2in+xLCMAfe13uQdC9ZkdSu /l1MX/nAJ99AAxxsxM3aUZKNdzDMiY8kZ94gMFC+yP6rx8IQJFfjZdKMaozCb4Y1ML/fMYOQgbeWa yQ4zqj/Q==; From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Marc Kleine-Budde , linux-can , 1579567540@qq.com Cc: Vincent Mailhol , Rob Herring , Krzysztof Kozlowski , kernel , Conor Dooley , Dmitry Torokhov , Shengjiu Wang , Pengpeng Hou , Russell King , Eric Biggers , Mario Limonciello , Karl Mehltretter , Yixun Lan , Stephen Boyd , devicetree , linux-arm-kernel , linux-rockchip , linux-kernel , Cunhao Lu <1579567540@qq.com>, Heiko Stuebner Subject: Re: [PATCH v2 2/4] can: rockchip: add RK3588 CAN support Date: Thu, 02 Jul 2026 18:02:25 +0200 Message-ID: <3527453.usfYGdeWWP@diego> In-Reply-To: References: <20260702140654.2961561-1-1579567540@qq.com> Precedence: bulk X-Mailing-List: linux-can@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Am Donnerstag, 2. Juli 2026, 16:06:52 Mitteleurop=C3=A4ische Sommerzeit sch= rieb 1579567540@qq.com: > From: Cunhao Lu <1579567540@qq.com> >=20 > Add support for the RK3588 CAN controller by introducing a dedicated > model ID and OF match entry. >=20 > The block is closely related to the existing RK3568 variants, but it > cannot reuse their match data unchanged. In particular, RK3588 > encodes RX_FIFO_CNT in bits 7:5 instead of 6:4, so the RX path needs > SoC-specific handling. >=20 > The RX FIFO count bitfield difference was found by comparing Rockchip's > vendor kernel 6.1 CAN support for RK3568 and RK3588. Runtime testing on > RK3588 also confirms that bits 7:5 are needed. >=20 > Enable the existing erratum 5 empty-FIFO workaround for RK3588. > Heiko reproduced erratum 6 on RK3588, so enable that workaround as > well. >=20 > Keep RKCANFD_QUIRK_CANFD_BROKEN enabled for RK3588, so CAN-FD stays > disabled for now. Local testing did not reproduce the two known CAN-FD > trigger frames that cause Error Interrupts on RK3568 variants. Instead, > RK3588 shows a different CAN-FD failure mode: CAN-FD frames without BRS > work in this setup, but BRS with a data bitrate different from the > nominal bitrate immediately drives the controller bus-off. >=20 > Reported-by: Heiko Stuebner > Link: https://lore.kernel.org/lkml/20260630164336.3444550-4-heiko@sntech.= de/ I think you might want to drop that above. If anything a Co-developed-by would be applicable, but from the (small) size of the change, that also isn't really necessary for me :-) > Signed-off-by: Cunhao Lu <1579567540@qq.com> Tested-by: Heiko Stuebner Reviewed-by: Heiko Stuebner