Re: [PATCH v3 1/2] can: m_can: tcan4x5x: put the device out of standby before register access

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1.1: Type: text/plain, Size: 2833 bytes --]

On 12/11/19 10:13 AM, Sean Nyekjaer wrote:
>>> When the tcan device comes out of reset it comes out in standby mode.
>>> The m_can driver tries to access the control register but fails due to
>>> the device is in standby mode.
>>> So this patch will put the tcan device in normal mode before the m_can
>>> driver does the initialization.
>>>
>>> Fixes: a229abeed7f7 ("can: tcan4x5x: Turn on the power before parsing the config")
>>> Cc: stable@vger.kernel.org
>>> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
>>
>> Applied both to linux-can.
> 
> Oh, the commit id for "can: tcan4x5x: Turn on the power before parsing 
> the config" have changed, since this morning :)

Ahh, I see.

Until there is a pull request (including a tag) the testing branch is
subject to rebase. Meaning, when there is a patch, that needs update I'm
happy to squash things into it.

I'm squashing there two commits into one:

> # This is a combination of 2 commits.
> # This is the 1st commit message:
> 
> can: tcan4x5x: Turn on the power before parsing the config
> 
> The parse config function now performs action on the device either
> reading or writing and a reset.  If the regulator is managed it needs
> to be turned on.  So turn on the regulator if available if the parsing
> fails then turn off the regulator.
> 
> Fixes: a5235f3c7c23 ("can: tcan45x: Make wake-up GPIO an optional GPIO")
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> 
> # This is the commit message #2:
> 
> can: tcan4x5x: put the device out of standby before register access
> 
> The m_can tries to detect if Non ISO Operation is available while in
> standby, this function results in the following error:
> 
> tcan4x5x spi2.0 (unnamed net_device) (uninitialized): Failed to init module
> tcan4x5x spi2.0: m_can device registered (irq=84, version=32)
> tcan4x5x spi2.0 can2: TCAN4X5X successfully initialized.
> 
> When the tcan device comes out of reset it comes out in standby mode.
> The m_can driver tries to access the control register but fails due to
> the device is in standby mode.
> 
> So this patch will put the tcan device in normal mode before the m_can
> driver does the initialization.
> 
> Fixes: a229abeed7f7 ("can: tcan4x5x: Turn on the power before parsing the config")
> Cc: stable@vger.kernel.org
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

Can you give me an updated commit message?

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]