Re: [PATCH v2 1/4] dt-bindings: can: rockchip: add rk3588 CAN-FD compatible

["Heiko Stübner" <heiko@sntech.de>]

Am Donnerstag, 2. Juli 2026, 18:39:53 Mitteleuropäische Sommerzeit schrieb Krzysztof Kozlowski:
> On 02/07/2026 18:01, Heiko Stübner wrote:
> > Am Donnerstag, 2. Juli 2026, 16:06:51 Mitteleuropäische Sommerzeit schrieb 1579567540@qq.com:
> >> From: Cunhao Lu <1579567540@qq.com>
> >>
> >> RK3588 integrates a Rockchip CAN-FD controller variant that is not
> >> fully compatible with RK3568v2. The RX FIFO count register field is
> >> encoded in bits 7:5 on RK3588, while RK3568v2 uses bits 6:4.
> >>
> >> Add a dedicated rockchip,rk3588-canfd compatible to describe this
> >> variant. Do not use rockchip,rk3568v2-canfd as a fallback, because that
> >> would describe a register layout that does not match the hardware.
> >>
> >> Changes in v2:
> >> - Use enum for the single-compatible entries, as suggested by Krzysztof.
> >> - Reword the commit message to explain the hardware difference instead
> >>   of referring to Linux driver match data.
> >>
> >> Signed-off-by: Cunhao Lu <1579567540@qq.com>
> > 
> > after fixing  Krzysztof's comment:
> > Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> > 
> > and doing dtbscheck of the binding against the dt-patches:
> > Tested-by: Heiko Stuebner <heiko@sntech.de>
> 
> Makefile/build level steps are not testing. Please don't provide such
> tags for bindings. Otherwise all bindings would carry Rob's tag, because
> he wrote the bot which does such testing.

ok ... will keep that in mind for the future


Heiko