From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Ulrich Hecht <uli+renesas@fpond.eu>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-can@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: can: renesas,rcar-canfd: Fix number of channels for R-Car V3U
Date: Fri, 2 Dec 2022 11:49:35 +0100 [thread overview]
Message-ID: <433b5f09-e14f-b29a-782b-2eef4ae3eada@linaro.org> (raw)
In-Reply-To: <CAMuHMdWd3KikD=HKFTorQvD_yGRvP3zCBF=FMJQvrLnF6VX5eA@mail.gmail.com>
On 02/12/2022 10:25, Geert Uytterhoeven wrote:
> Hi Krzysztof,
>
> On Fri, Dec 2, 2022 at 10:01 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>> On 02/12/2022 09:22, Geert Uytterhoeven wrote:
>>> According to the bindings, only two channels are supported.
>>> However, R-Car V3U supports eight, leading to "make dtbs" failures:
>>>
>>> arch/arm64/boot/dts/renesas/r8a779a0-falcon.dtb: can@e6660000: Unevaluated properties are not allowed ('channel2', 'channel3', 'channel4', 'channel5', 'channel6', 'channel7' were unexpected)
>>>
>>> Update the number of channels to 8 on R-Car V3U.
>>> While at it, prevent adding more properties to the channel nodes, as
>>> they must contain no other properties than a status property.
>>>
>>> Fixes: d6254d52d70de530 ("dt-bindings: can: renesas,rcar-canfd: Document r8a779a0 support")
>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
>>> --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
>>> +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
>
>>> description: Maximum frequency of the CANFD clock.
>>>
>>> patternProperties:
>>> - "^channel[01]$":
>>> + "^channel[0-7]$":
>>> type: object
>>> description:
>>> - The controller supports two channels and each is represented as a child
>>> - node. Each child node supports the "status" property only, which
>>> + The controller supports multiple channels and each is represented as a
>>> + child node. Each child node supports the "status" property only, which
>>> is used to enable/disable the respective channel.
>>>
>>> + unevaluatedProperties: false
>>
>> There are no other properties within a channel, so this should be rather
>> additionalProperties: false.
>
> Are you sure? Then I also have to add:
>
> properties:
> status: true
>
Do you? I think it would be first schema needing it, so maybe that would
be a problem for dtschema...
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-02 10:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 8:22 [PATCH] dt-bindings: can: renesas,rcar-canfd: Fix number of channels for R-Car V3U Geert Uytterhoeven
2022-12-02 9:01 ` Krzysztof Kozlowski
2022-12-02 9:25 ` Geert Uytterhoeven
2022-12-02 10:49 ` Krzysztof Kozlowski [this message]
2022-12-02 10:58 ` Geert Uytterhoeven
2022-12-05 20:25 ` Rob Herring
2022-12-06 8:29 ` Geert Uytterhoeven
2022-12-05 20:59 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=433b5f09-e14f-b29a-782b-2eef4ae3eada@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert@linux-m68k.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=uli+renesas@fpond.eu \
--cc=wg@grandegger.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).