Re: Using sja1000_isa on a 64b system

[Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>]

On 11/13/2011 10:15 AM, Willy Lambert wrote:
> 2011/11/13 Willy Lambert <lambert.willy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
>> 2011/11/12 Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>:
>>> On 11/12/2011 10:08 PM, Wolfgang Grandegger wrote:
>>>> On 11/12/2011 10:55 AM, Willy Lambert wrote:
>>> ...
>>>>>> I failed to apply the patch, is it for 2.6.38.8 kernels ?
>>>>
>>>> No, it's for up-to-date *mainline* linux version 3.1.x. Any chance to
>>>> switch to David Miller's "net-nex-2.6" tree?. Otherwise I'm going to
>>>> adapt the patch to 2.6.38.8.
>>>
>>> Well, the patch also applies to 2.6.38.8. Maybe you have some problems
>>> extracting the patch. Therefore I have attached it as attachment this
>>> time. Good luck.
>>
>> It's ok now :
>> ard@ard-host:~/src/linux-2.6.38.8$ patch -p1 < wg_platform.patch
>> patching file drivers/net/can/sja1000/Kconfig
>> patching file drivers/net/can/sja1000/sja1000_isa.c
>>
>> I must have done something wrong. I am going to test it now
>>
> 
> arg, it doesn't compile I had a look a sources but I don't see the error :
> 
>   CC [M]  drivers/xenomai/can/rtcan_raw_dev.o
> drivers/net/can/sja1000/sja1000_isa.c: In function ‘sja1000_isa_init’:
> drivers/net/can/sja1000/sja1000_isa.c:297: error: invalid storage
> class for function ‘sja1000_isa_exit’
> drivers/net/can/sja1000/sja1000_isa.c:296: warning: ISO C90 forbids
> mixed declarations and code
> drivers/net/can/sja1000/sja1000_isa.c:307: error: invalid storage
> class for function ‘__inittest’
> drivers/net/can/sja1000/sja1000_isa.c:307: warning: ‘alias’ attribute ignored
> drivers/net/can/sja1000/sja1000_isa.c:308: error: invalid storage
> class for function ‘__exittest’
> drivers/net/can/sja1000/sja1000_isa.c:308: warning: ISO C90 forbids
> mixed declarations and code
> drivers/net/can/sja1000/sja1000_isa.c:308: warning: ‘alias’ attribute ignored
> drivers/net/can/sja1000/sja1000_isa.c:308: error: expected declaration
> or statement at end of input
> make[5]: *** [drivers/net/can/sja1000/sja1000_isa.o] Error 1

Argh, a "}" is missing, sorry. I will test the patch more carefully
before re-sending.

Wolfgang.