* [PATCH 11/11] can: Remove redundant spi driver bus initialization [not found] <1322148561-25138-1-git-send-email-lars@metafoo.de> @ 2011-11-24 15:29 ` Lars-Peter Clausen 2011-11-24 15:36 ` Marc Kleine-Budde 0 siblings, 1 reply; 2+ messages in thread From: Lars-Peter Clausen @ 2011-11-24 15:29 UTC (permalink / raw) To: linux-kernel; +Cc: Lars-Peter Clausen, Wolfgang Grandegger, linux-can In ancient times it was necessary to manually initialize the bus field of an spi_driver to spi_bus_type. These days this is done in spi_driver_register(), so we can drop the manual assignment. The patch was generated using the following coccinelle semantic patch: // <smpl> @@ identifier _driver; @@ struct spi_driver _driver = { .driver = { - .bus = &spi_bus_type, }, }; // </smpl> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Cc: Wolfgang Grandegger <wg@grandegger.com> Cc: linux-can@vger.kernel.org --- drivers/net/can/mcp251x.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/can/mcp251x.c b/drivers/net/can/mcp251x.c index 330140e..5e10da5 100644 --- a/drivers/net/can/mcp251x.c +++ b/drivers/net/can/mcp251x.c @@ -1185,7 +1185,6 @@ MODULE_DEVICE_TABLE(spi, mcp251x_id_table); static struct spi_driver mcp251x_can_driver = { .driver = { .name = DEVICE_NAME, - .bus = &spi_bus_type, .owner = THIS_MODULE, }, -- 1.7.7.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 11/11] can: Remove redundant spi driver bus initialization 2011-11-24 15:29 ` [PATCH 11/11] can: Remove redundant spi driver bus initialization Lars-Peter Clausen @ 2011-11-24 15:36 ` Marc Kleine-Budde 0 siblings, 0 replies; 2+ messages in thread From: Marc Kleine-Budde @ 2011-11-24 15:36 UTC (permalink / raw) To: Lars-Peter Clausen; +Cc: linux-kernel, Wolfgang Grandegger, linux-can [-- Attachment #1: Type: text/plain, Size: 1463 bytes --] On 11/24/2011 04:29 PM, Lars-Peter Clausen wrote: > In ancient times it was necessary to manually initialize the bus field of an > spi_driver to spi_bus_type. These days this is done in spi_driver_register(), > so we can drop the manual assignment. > > The patch was generated using the following coccinelle semantic patch: > // <smpl> > @@ > identifier _driver; > @@ > struct spi_driver _driver = { > .driver = { > - .bus = &spi_bus_type, > }, > }; > // </smpl> > > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> > Cc: Wolfgang Grandegger <wg@grandegger.com> > Cc: linux-can@vger.kernel.org Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> > --- > drivers/net/can/mcp251x.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/can/mcp251x.c b/drivers/net/can/mcp251x.c > index 330140e..5e10da5 100644 > --- a/drivers/net/can/mcp251x.c > +++ b/drivers/net/can/mcp251x.c > @@ -1185,7 +1185,6 @@ MODULE_DEVICE_TABLE(spi, mcp251x_id_table); > static struct spi_driver mcp251x_can_driver = { > .driver = { > .name = DEVICE_NAME, > - .bus = &spi_bus_type, > .owner = THIS_MODULE, > }, > -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 262 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-24 15:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1322148561-25138-1-git-send-email-lars@metafoo.de>
2011-11-24 15:29 ` [PATCH 11/11] can: Remove redundant spi driver bus initialization Lars-Peter Clausen
2011-11-24 15:36 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).