Re: [Gitorious] Activity: dschanoeh updated merge request for...

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 3710 bytes --]

Hello Jan-Niklas,

please don't top-post.

On 12/03/2011 05:47 PM, Jan-Niklas Meier wrote:
> 1.
> I think adding the includes to the repository is a bad idea. If you compile
> the utils for your machine which has a kernel with SocketCAN-support why
> not use the original kernel headers?

Several reasons:
- iputils2 package the kernel headers, too.
- Consider you're using an older kernel without official socketcan
  support and with the external kernel modules available on gitorious.
- What about isotp and/or j1939 support? You want to use new features
  which are not part of the mainline kernel yet.

> It makes no sense to compile the can-utils on a machine which does not have
> SocketCAN support. If you do so you should be cross-compiling for a
> different machine and have the kernel headers of this machine in your
> cross-environment.
> Also it is very unlikely that someone who installed make, gcc and the
> autotools does not also have his kernel includes, right?

> To be able to compile a subset of the tools I checked if the isotp.h and
> gw.h are present in the include directory (I don't have them both) and only
> compile the corresponding utils if the headers are present. This way it
> should still be possible to compile subsets of the tools on machines with
> old kernels and not ending up with tools you can not use afterwards.

What about the external kernel modules use case?

> 2.
> I tried to rewrite the autoconf.ac because there are macros I'm having

Please don't rewrite stuff, please send incremental patches, fixing one
problem at a time.

> trouble with. When I run autoconf (version 2.68, libtool and automake
> installed) I get the following output:
> 
> configure.ac:22: error: possibly undefined macro: AC_LIBTOOL_WIN32_DLL
>       If this token and others are legitimate, please use m4_pattern_allow.
>       See the Autoconf documentation.
> configure.ac:24: error: possibly undefined macro: AC_PROG_LIBTOOL
> configure.ac:28: error: possibly undefined macro: AM_INIT_AUTOMAKE
> 
> A configure script is produced but when I try to execute it I get (shtool
> is installed):
> 
> configure: error: cannot find install-sh, install.sh, or shtool in
> config/autoconf "."/config/autoconf
> 
> Trying to make it work (and not knowing what the macros do anyway ;) I
> removed them and successfully ran autoconf with my configure.ac...
                                    ^^^^^^^^

That might be the problem, don't run autoconf, run $(./autogen.sh) instead.

I just updated to the latest tool available on debian unstable and it works:

> [frogger@hardanger:can-utils (master-squashed)]$ autoconf --version
> autoconf (GNU Autoconf) 2.68
[..]

> automake (GNU automake) 1.11.1
[..]

> [frogger@hardanger:can-utils (master-squashed)]$ libtoolize --version
> libtoolize (GNU libtool) 2.4.2
[..]

> [frogger@hardanger:can-utils (master-squashed)]$ ./autogen.sh && ./configure && make distcheck
[...]
> =================================================
> can-utils-trunk archives ready for distribution:
> can-utils-trunk.tar.gz
> can-utils-trunk.tar.bz2
> =================================================

I used the master-squashed branch of my can-utils repo:
https://gitorious.org/~bet-frogger/linux-can/mkl-can-utils, head is:

231ed32f497a4f403a6d0ce2a61f1bb94be76ea4 gitignore: added tarballs

cheers, Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]