Re: WG: PCAN-USB: new socketCAN driver available

[Oliver Hartkopp <socketcan@hartkopp.net>]

On 06.12.2011 20:49, Oliver Hartkopp wrote:

>> +config CAN_PEAK_PCAN_USB_PRO
> 
> CAN_PEAK_USB_PRO
> 
>> +       tristate "PEAK-System's PCAN-USB-PRO adapter"
> 
> "PEAK PCAN USB Pro adapter"
> 
>> +       select CAN_PEAK_USB
> 
> remove the select (see Makefile comment below)
> 
>> +       ---help---
>> +         This driver is for the two channels PCAN-USB-PRO interface
> 
> PCAN-USB Pro
> 
>> +         from PEAK-System (http://www.peak-system.com).
>> +
>> +config CAN_PEAK_USB
>> +       tristate
>> +
> 
> Remove this.
> 
> To select config entries should be omitted if possible.


I just tried out the suggestion myself ...

As my idea was to link the common functions directly to the module binary this
may double the needed size. Maybe your approach is really better 8-)

But the fact that the select should be omitted is still true.

Better you define a

config CAN_PEAK_USB
	tristate "PEAK System USB adapters"

and then

config CAN_PCAN_USB
	tristate "PEAK PCAN USB adapter"
	depends on CAN_PEAK_USB


config CAN_PCAN_USB_PRO
	tristate "PEAK PCAN USB Pro adapter"
	depends on CAN_PEAK_USB

...

Regards,
Oliver