From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Sam Ravnborg <sam.ravnborg@gmail.com>
Cc: s.grosjean@peak-system.com, "Maidhof,
Michael" <m.maidhof@peak-system.com>,
linux-can@vger.kernel.org
Subject: Re: WG: PCAN-USB: new socketCAN driver available
Date: Tue, 06 Dec 2011 22:24:53 +0100 [thread overview]
Message-ID: <4EDE8825.80901@hartkopp.net> (raw)
In-Reply-To: <CAMGS=fBKG-X_dxeqPows0fteLEEFC7ZSiWyU+_r9j8w_CYSiqA@mail.gmail.com>
On 06.12.2011 21:47, Sam Ravnborg wrote:
> Hi Oliver.
>
> One not to your comments..
>
>> in the linux/drivers/net/can/usb/Makefile it should look like this:
>>
>> obj-$(CONFIG_CAN_PEAK_USB) += peak_usb.o
>> peak_usb-objs := pcan_usb_core.o pcan_usb.o
>>
>> obj-$(CONFIG_CAN_PEAK_USB_PRO) += peak_usb_pro.o
>> peak_usb_pro-objs := pcan_usb_core.o pcan_usb_pro.o
>
> Today it is really recommended to do:
>
> obj-$(CONFIG_CAN_PEAK_USB) += peak_usb.o
> peak_usb-y := pcan_usb_core.o pcan_usb.o
>
> obj-$(CONFIG_CAN_PEAK_USB_PRO) += peak_usb_pro.o
> peak_usb_pro-y := pcan_usb_core.o pcan_usb_pro.o
>
> Both solutions will work - but the latter allows for some nice
> "kbuild" assignments to conditional stuff.
>
Ah ok,
i picked that from here:
http://patchwork.ozlabs.org/patch/129539/
Good to know that it can be made 'even better' :-)
Thanks,
Oliver
next prev parent reply other threads:[~2011-12-06 21:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4E400A36.5050303@hartkopp.net>
[not found] ` <A46279271E5345AC9BFA91C73DF57228@DA310MM05>
[not found] ` <4E415AB2.5030102@hartkopp.net>
[not found] ` <2CD045C79786404EA0A81CED1E59763D@DA310MM05>
[not found] ` <4E4BFF24.2010508@hartkopp.net>
[not found] ` <33575A72304940CE9103338BA3660CEA@DA310MM05>
[not found] ` <26B4E6A46012A1469B4EB3BC2A7CAAEC01266CCC@vwagwox00084.vw.vwg>
[not found] ` <4EC6597A.8040704@peak-system.com>
[not found] ` <4EC6B080.8090808@hartkopp.net>
[not found] ` <4ECB65D8.7050207@peak-system.com>
[not found] ` <4ECB8E75.7@volkswagen.de>
[not found] ` <4ECBAAFB.8080204@peak-system.com>
[not found] ` <4ECBAE4E.8000502@volkswagen.de>
[not found] ` <4ECBB49A.2020508@volkswagen.de>
[not found] ` <4ED3B355.70209@peak-system.com>
[not found] ` <26B4E6A46012A1469B4EB3BC2A7CAAECE55502@vwagwox00084.vw.vwg>
[not found] ` <4ED3CC05.6060606@hartkopp.net>
[not found] ` <4ED4AF93.8060309@peak-system.com>
2011-11-29 10:39 ` WG: PCAN-USB: new socketCAN driver available Wolfgang Grandegger
2011-11-29 10:43 ` Marc Kleine-Budde
2011-12-06 19:49 ` Oliver Hartkopp
2011-12-06 20:40 ` Oliver Hartkopp
2011-12-09 13:47 ` PEAK CAN USB driver v0.4.0 Grosjean Stephane
2011-12-06 20:47 ` WG: PCAN-USB: new socketCAN driver available Sam Ravnborg
2011-12-06 21:24 ` Oliver Hartkopp [this message]
2011-12-07 10:29 ` Grosjean Stephane
2011-12-07 11:15 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDE8825.80901@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=linux-can@vger.kernel.org \
--cc=m.maidhof@peak-system.com \
--cc=s.grosjean@peak-system.com \
--cc=sam.ravnborg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).