Re: CAN State Information

[Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>]

Hello James,

On 12/08/2011 09:43 AM, kime-Z4QKGCRq86k@public.gmane.org wrote:
> Hello,
> Thanks for the response.  I am using can_get_state() as part of my start_CAN routine.  After, I call can_do_start(), I read the state to see if I need to do bus-off recovery.  So it is not a frequent call.  I was able to see the states correctly on all four CAN channels with "ip -d -s link".  

OK, just to be sure. Does the "canconfig canX state" from the
Pengutronix canutils list the state correctly for any device?
I just tried here and it works fine.

> I updated the code in plx_pci.c to include support for the IXXAT card.  I wanted to ask you how to submit the changes since I have not done it before.  I attached a patch file.

Nice! A patch should be submitted as *inline* mail to the linux-can
*and* netdev mailing list with a proper subject, patch description and
signed-off-by line. The subject line should be something like:

"[PATCH net-next] can: plx_pci: add support for IXXAT PCI cards"

It's best to use git to create and send the patch but for simple patches
it doesn't really matter.

Wolfgang.