linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Grosjean Stephane <s.grosjean@peak-system.com>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: "Maidhof, Michael" <m.maidhof@peak-system.com>,
	linux-can@vger.kernel.org,
	"Uwe Wilhelm (PEAK-System)" <u.wilhelm@peak-system.com>
Subject: PEAK CAN USB driver v0.4.0
Date: Fri, 09 Dec 2011 14:47:41 +0100	[thread overview]
Message-ID: <4EE2117D.6020505@peak-system.com> (raw)
In-Reply-To: <4EDE7DAC.3090709@hartkopp.net>

[-- Attachment #1: Type: text/plain, Size: 1788 bytes --]

Hi Oliver,

Please find a new version of the candev driver for our PEAK USB adapters.
I tried to follow your suggestions, especially those concerning the 
names of the files and the Kconfig file content. However, I kept the 
original Kbuild file since I didn't find (for the moment) another way to 
add one or the other pcan_usb.o/pcan_usb_pro.o file, according to their 
corresponding CONFIG_xxx ...

This version also handles the PCAN-USB Pro adapter as well as the 
timestamps coming from PCAN-USB and PCAN-USB Pro (new from v0.2.0).
There's something which should be fixed too and I wanted to talk about 
that too:

I don't know why for the moment, but sending data through the adapters 
works without any problems, except when data are sent through one or the 
other can channel of the the PCAN-USB Pro: the data are correclty sent 
on the bus but, for each sent frame, the Kernel adds the following text 
to the syslog:

     [98724.131218] ehci_hcd 0000:00:1a.7: dma_pool_free buffer-32, 
f4e93000/34e93000 (bad dma)

Seems to be a warning-like, since nothing else occurs anywhere (data are 
sent, the kernel is/seems always stable...).
That's the main reason why I decided to give you that new version, and 
also to ask you if you had got any idea about the reason of such a log? 
I mean, that "problem" doesnot occur when sending through PCAN-USB 
adapter channel... If you have a look to the sources, the management of 
the tx buffer(s) is done into pcan_usb_core.c, that is, tx buffers 
allocation/free doesn't depend on the type of USB adapter (well I 
suppose it is, but why and where?).

So, while I'm delving into the code, I hope you'll be able to have 
enough time to test'n play with your PEAK USB CAN adapters and this new 
driver.

Many thanks and regards,

Stéphane


[-- Attachment #2: peak_usb-0.4.0.tar.gz --]
[-- Type: application/gzip, Size: 45725 bytes --]

  reply	other threads:[~2011-12-09 13:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4E400A36.5050303@hartkopp.net>
     [not found] ` <A46279271E5345AC9BFA91C73DF57228@DA310MM05>
     [not found]   ` <4E415AB2.5030102@hartkopp.net>
     [not found]     ` <2CD045C79786404EA0A81CED1E59763D@DA310MM05>
     [not found]       ` <4E4BFF24.2010508@hartkopp.net>
     [not found]         ` <33575A72304940CE9103338BA3660CEA@DA310MM05>
     [not found]           ` <26B4E6A46012A1469B4EB3BC2A7CAAEC01266CCC@vwagwox00084.vw.vwg>
     [not found]             ` <4EC6597A.8040704@peak-system.com>
     [not found]               ` <4EC6B080.8090808@hartkopp.net>
     [not found]                 ` <4ECB65D8.7050207@peak-system.com>
     [not found]                   ` <4ECB8E75.7@volkswagen.de>
     [not found]                     ` <4ECBAAFB.8080204@peak-system.com>
     [not found]                       ` <4ECBAE4E.8000502@volkswagen.de>
     [not found]                         ` <4ECBB49A.2020508@volkswagen.de>
     [not found]                           ` <4ED3B355.70209@peak-system.com>
     [not found]                             ` <26B4E6A46012A1469B4EB3BC2A7CAAECE55502@vwagwox00084.vw.vwg>
     [not found]                               ` <4ED3CC05.6060606@hartkopp.net>
     [not found]                                 ` <4ED4AF93.8060309@peak-system.com>
2011-11-29 10:39                                   ` WG: PCAN-USB: new socketCAN driver available Wolfgang Grandegger
2011-11-29 10:43                                     ` Marc Kleine-Budde
2011-12-06 19:49                                   ` Oliver Hartkopp
2011-12-06 20:40                                     ` Oliver Hartkopp
2011-12-09 13:47                                       ` Grosjean Stephane [this message]
2011-12-06 20:47                                     ` Sam Ravnborg
2011-12-06 21:24                                       ` Oliver Hartkopp
2011-12-07 10:29                                         ` Grosjean Stephane
2011-12-07 11:15                                           ` Oliver Hartkopp
2011-12-09 14:21 PEAK CAN USB driver v0.4.0 Oliver Hartkopp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE2117D.6020505@peak-system.com \
    --to=s.grosjean@peak-system.com \
    --cc=linux-can@vger.kernel.org \
    --cc=m.maidhof@peak-system.com \
    --cc=socketcan@hartkopp.net \
    --cc=u.wilhelm@peak-system.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).