Re: PEAK CAN USB driver patch

[Oliver Hartkopp <socketcan@hartkopp.net>]

On 09.12.2011 18:08, Grosjean Stephane wrote:

> Hi Oliver,
> 
> Please find below the patch to apply to linux-can-next, which adds support for
> the PEAK System CAN USB adapters.


Whow - thanks!

I already transferred your original patch into my tree by hand :-)

And the first thing i stumble when compiling was here:

> diff --git a/drivers/net/can/usb/pcan_usb.c b/drivers/net/can/usb/pcan_usb.c
> new file mode 100644
> index 0000000..eb2329d
> --- /dev/null
> +++ b/drivers/net/can/usb/pcan_usb.c
> @@ -0,0 +1,740 @@
> +/*
> + * CAN driver for PEAK System PCAN-USB adapter
> + *
> + * Copyright (C) 2011-2012 PEAK-System GmbH
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published
> + * by the Free Software Foundation; version 2 of the License.
> + *
> + * This program is distributed in the hope that it will be useful, but
> + * WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License along
> + * with this program; if not, write to the Free Software Foundation, Inc.,
> + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> + */
> +#include <linux/netdevice.h>
> +#include <linux/usb.h>


here

#include <linux/module.h>

is missing to expand this:

> +MODULE_SUPPORTED_DEVICE("PEAK-System PCAN-USB adapter");

> new file mode 100644
> index 0000000..c81b42d
> --- /dev/null
> +++ b/drivers/net/can/usb/pcan_usb_pro.c
> @@ -0,0 +1,1426 @@
> +/*
> + * CAN driver for PEAK System PCAN-USB-PRO adapter
> + *
> + * Copyright (C) 2011-2012 PEAK-System GmbH
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published
> + * by the Free Software Foundation; version 2 of the License.
> + *
> + * This program is distributed in the hope that it will be useful, but
> + * WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License along
> + * with this program; if not, write to the Free Software Foundation, Inc.,
> + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> + */
> +#include <linux/netdevice.h>
> +#include <linux/usb.h>
> +#include <linux/stringify.h>



here

#include <linux/module.h>

is missing to expand this:

> +MODULE_SUPPORTED_DEVICE("PEAK-System PCAN-USB-PRO adapter");


More remarks following soon ...

Have a nice weekend,

Oliver