From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Grandegger <wg@grandegger.com>
Subject: Re: "[PATCH] Add support for PEAK-System GmbH CAN USB adapters (v2)
 "
Date: Tue, 20 Dec 2011 16:57:33 +0100
Message-ID: <4EF0B06D.4040109@grandegger.com>
References: <301939.630738588-sendEmail@ubuntu-i386> <4EEB3C66.1020303@pengutronix.de> <4EF07B1F.4040609@peak-system.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-can-owner@vger.kernel.org>
Received: from ngcobalt02.manitu.net ([217.11.48.102]:53309 "EHLO
	ngcobalt02.manitu.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751516Ab1LTP5n (ORCPT
	<rfc822;linux-can@vger.kernel.org>); Tue, 20 Dec 2011 10:57:43 -0500
In-Reply-To: <4EF07B1F.4040609@peak-system.com>
Sender: linux-can-owner@vger.kernel.org
List-ID: <linux-can.vger.kernel.org>
To: s.grosjean@peak-system.com
Cc: Marc Kleine-Budde <mkl@pengutronix.de>, "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>

Hallo St=E9phane,

On 12/20/2011 01:10 PM, Grosjean Stephane wrote:
> Hi Marc,
>=20
> Thanks for your review. Please, find my answers and comments below...
=2E..
> Le 16/12/2011 13:41, Marc Kleine-Budde a =E9crit :
>> please talk to Wolfgang for the error handling, he is the expert now=
 :)
>=20
> ???
> What should I talk about? Is the way errors are handling wrong?

Please fix your coding style first, then I will have a closer look.


Wolfgang.