From: Wolfgang Grandegger <wg@grandegger.com>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Stephane Grosjean <s.grosjean@peak-system.com>,
Linux CAN mailing list <linux-can@vger.kernel.org>
Subject: Re: [PATCH] Add PEAK System USB adapters core driver
Date: Tue, 10 Jan 2012 16:35:29 +0100 [thread overview]
Message-ID: <4F0C5AC1.2070806@grandegger.com> (raw)
In-Reply-To: <4F0C57B9.2020204@hartkopp.net>
On 01/10/2012 04:22 PM, Oliver Hartkopp wrote:
> On 10.01.2012 11:17, Wolfgang Grandegger wrote:
>
>>> drivers/net/can/usb/Kconfig | 1 +
>>> drivers/net/can/usb/Makefile | 1 +
>>> drivers/net/can/usb/peak_usb/Kconfig | 19 +
>>> drivers/net/can/usb/peak_usb/Makefile | 10 +
>>> drivers/net/can/usb/peak_usb/pcan_usb_core.c | 893 ++++++++++++++++++++++++++
>>> drivers/net/can/usb/peak_usb/peak_usb.h | 149 +++++
>>> 6 files changed, 1073 insertions(+), 0 deletions(-)
>>> create mode 100644 drivers/net/can/usb/peak_usb/Kconfig
>>> create mode 100644 drivers/net/can/usb/peak_usb/Makefile
>>> create mode 100644 drivers/net/can/usb/peak_usb/pcan_usb_core.c
>>
>> Why not naming the file peak_usb.c? You already use "peak_usb" for the
>> header file as function prefix inside!
>
>
> AFAIR the driver built results in peak_usb.ko
>
> And the driver contains the pcan_usb.c and pcan_usb_pro.c
>
> If it's possible from the build process pcan_usb_core.c should be renamed to
> peak_usb.c - that's right.
We should remove the device specific Kconfigs including the related
#ifdefs. It's then *one* driver which always supports the two USB
devices. Anything else does not really make sense. Maybe just for very
low end devices where any byte counts. Have a look to other USB drivers.
They supports tons of devices without any #ifdef.
Wolfgang.
next prev parent reply other threads:[~2012-01-10 15:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 13:11 [PATCH] Add PEAK System USB adapters core driver Stephane Grosjean
2011-12-22 21:41 ` Sebastian Haas
2011-12-23 9:33 ` Grosjean Stephane
2011-12-23 11:48 ` dev
2012-01-10 12:53 ` Marc Kleine-Budde
2012-01-10 10:17 ` Wolfgang Grandegger
2012-01-10 15:22 ` Oliver Hartkopp
2012-01-10 15:35 ` Wolfgang Grandegger [this message]
2012-01-11 9:23 ` Grosjean Stephane
2012-01-11 9:50 ` Marc Kleine-Budde
2012-01-11 10:09 ` Grosjean Stephane
2012-01-11 10:12 ` Wolfgang Grandegger
2012-01-11 10:29 ` Oliver Hartkopp
2012-01-11 12:28 ` Wolfgang Grandegger
2012-01-11 9:59 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0C5AC1.2070806@grandegger.com \
--to=wg@grandegger.com \
--cc=linux-can@vger.kernel.org \
--cc=s.grosjean@peak-system.com \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).