From: Stephane Grosjean <s.grosjean@peak-system.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Oliver Hartkopp <socketcan@hartkopp.net>,
linux-can Mailing List <linux-can@vger.kernel.org>
Subject: Re: [PATCH 1/2] can/sja1000: Add PEAK-System PCIe/PCIeC and miniPCI boards
Date: Tue, 31 Jan 2012 16:01:25 +0100 [thread overview]
Message-ID: <4F280245.60809@peak-system.com> (raw)
In-Reply-To: <4F27EBC5.3060805@pengutronix.de>
Hi Marc,
What do you mean please? You want me to post 4 patches? One for each new
board, plus one for the channels list management? For 2 of the 3 boards,
this is as simple as adding a line into the device ids table, excepting
the ExpressCard for which I added the management of the funky leds.
Thanks for any clarification.
Stéphane
Le 31/01/2012 14:25, Marc Kleine-Budde a écrit :
> On 01/31/2012 02:19 PM, Stephane Grosjean wrote:
>> This patch adds the support of some new PEAK-System Technik sja1000 boards
>> (http://www.peak-system.com):
>>
>> PCAN-PCI Express (1 or 2 channels)
>> PCAN-ExpressCard (1 or 2 channels)
>> PCAN-miniPCI (1 or 2 channels)
>>
>> All of these boards are compliant with CAN specifications 2.0A (11-bit ID) and
>> 2.0B (29-bit ID).
>>
>> This patch also fixes the management of the channels list.
> Without looking further at the patch, please make it a seperate patch. A
> detailed review will follow.
>
>
> Marc
>
--
PEAK-System Technik GmbH, Otto-Roehm-Strasse 69, D-64293 Darmstadt
Geschaeftsleitung: A.Gach/U.Wilhelm,St.Nr.:007/241/13586 FA Darmstadt
HRB-9183 Darmstadt, Ust.IdNr.:DE 202220078, WEE-Reg.-Nr.: DE39305391
Tel.+49 (0)6151-817320 / Fax:+49 (0)6151-817329, info@peak-system.com
next prev parent reply other threads:[~2012-01-31 15:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 13:19 [PATCH 0/2] can/sja1000: Add/upgrade PEAK-System sja1000 driver Stephane Grosjean
2012-01-31 13:19 ` [PATCH 1/2] can/sja1000: Add PEAK-System PCIe/PCIeC and miniPCI boards Stephane Grosjean
2012-01-31 13:25 ` Marc Kleine-Budde
2012-01-31 15:01 ` Stephane Grosjean [this message]
2012-01-31 15:16 ` Wolfgang Grandegger
2012-01-31 15:26 ` Stephane Grosjean
2012-02-02 16:33 ` Stephane Grosjean
2012-01-31 16:55 ` Marc Kleine-Budde
2012-01-31 22:54 ` Marc Kleine-Budde
2012-01-31 13:19 ` [PATCH 2/2] can/sja1000: Add support of PEAK-System PCMCIA board Stephane Grosjean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F280245.60809@peak-system.com \
--to=s.grosjean@peak-system.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).