From: Marc Kleine-Budde <mkl@pengutronix.de>
To: s.grosjean@peak-system.com
Cc: Oliver Hartkopp <socketcan@hartkopp.net>,
linux-can Mailing List <linux-can@vger.kernel.org>
Subject: Re: [PATCH 1/2] can/sja1000: Add PEAK-System PCIe/PCIeC and miniPCI boards
Date: Tue, 31 Jan 2012 17:55:28 +0100 [thread overview]
Message-ID: <4F281D00.8070909@pengutronix.de> (raw)
In-Reply-To: <4F280245.60809@peak-system.com>
[-- Attachment #1: Type: text/plain, Size: 975 bytes --]
On 01/31/2012 04:01 PM, Stephane Grosjean wrote:
> Hi Marc,
>
> What do you mean please? You want me to post 4 patches? One for each new
> board, plus one for the channels list management? For 2 of the 3 boards,
> this is as simple as adding a line into the device ids table, excepting
> the ExpressCard for which I added the management of the funky leds.
> Thanks for any clarification.
[...]
Your patch states to fix a problem:
>>> This patch also fixes the management of the channels list.
>> Without looking further at the patch, please make it a seperate patch. A
>> detailed review will follow.
It would be better to fix the problem before adding new features.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-01-31 16:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 13:19 [PATCH 0/2] can/sja1000: Add/upgrade PEAK-System sja1000 driver Stephane Grosjean
2012-01-31 13:19 ` [PATCH 1/2] can/sja1000: Add PEAK-System PCIe/PCIeC and miniPCI boards Stephane Grosjean
2012-01-31 13:25 ` Marc Kleine-Budde
2012-01-31 15:01 ` Stephane Grosjean
2012-01-31 15:16 ` Wolfgang Grandegger
2012-01-31 15:26 ` Stephane Grosjean
2012-02-02 16:33 ` Stephane Grosjean
2012-01-31 16:55 ` Marc Kleine-Budde [this message]
2012-01-31 22:54 ` Marc Kleine-Budde
2012-01-31 13:19 ` [PATCH 2/2] can/sja1000: Add support of PEAK-System PCMCIA board Stephane Grosjean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F281D00.8070909@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=s.grosjean@peak-system.com \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).