From: Stephane Grosjean <s.grosjean@peak-system.com>
To: Wolfgang Grandegger <wg@grandegger.com>
Cc: linux-can Mailing List <linux-can@vger.kernel.org>
Subject: Re: [PATCH v3] peak_pci: add support for PEAK-System PCIe/PCIeC/miniPCI boards
Date: Wed, 01 Feb 2012 13:29:41 +0100 [thread overview]
Message-ID: <4F293035.2060201@peak-system.com> (raw)
In-Reply-To: <4F2929CD.90604@grandegger.com>
Le 01/02/2012 13:02, Wolfgang Grandegger a écrit :
> On 02/01/2012 12:02 PM, Stephane Grosjean wrote:
>> This patch adds the support for the following 3x sja1000 based PCI boards
>> from PEAK-System Technik (www.peak-system.com):
>>
>> PCAN-PCI Express (1 or 2 channels)
>> PCAN-ExpressCard (1 or 2 channels)
>> PCAN-miniPCI (1 or 2 channels)
>>
>> This version also updates Kconfig.
>>
>> Signed-off-by: Stephane Grosjean<s.grosjean@peak-system.com>
>> ---
>> drivers/net/can/sja1000/Kconfig | 7 +-
>> drivers/net/can/sja1000/peak_pci.c | 510 +++++++++++++++++++++++++++++++++--
>> 2 files changed, 484 insertions(+), 33 deletions(-)
>>
>> diff --git a/drivers/net/can/sja1000/Kconfig b/drivers/net/can/sja1000/Kconfig
>> index 36e9d59..d178e01 100644
>> --- a/drivers/net/can/sja1000/Kconfig
>> +++ b/drivers/net/can/sja1000/Kconfig
>> @@ -44,11 +44,12 @@ config CAN_EMS_PCI
>> (http://www.ems-wuensche.de).
>>
>> config CAN_PEAK_PCI
>> - tristate "PEAK PCAN PCI/PCIe Cards"
>> + tristate "PEAK PCAN-PCI/PCIe/PCIeC/miniPCI Cards"
>> depends on PCI
> It now also depends on I2C.
Yes you're right...but if I added such a dependency, I2C would be
mandatory, even for the other PEAK PCI boards
I would prefer:
1 - Changing Kconfig : like that
config CAN_PEAK_PCI
tristate "PEAK PCAN-PCI/PCIe/miniPCI Cards"
depends on PCI
---help---
This driver is for the PCAN-PCI/PCIe/miniPCI cards
(1, 2, 3 or 4 channels) from PEAK-System Technik
(http://www.peak-system.com).
The I2C driver must be selected to fully support the
PCAN-ExpressCard card LEDs.
config CAN_PEAK_PCIEC
bool "PEAK PCAN-ExpressCard Card"
depends on CAN_PEAK_PCI && I2C
---help---
Add full support of the PCAN-ExpressCard card
(1, 2, 3 or 4 channels) from PEAK-System Technik
(http://www.peak-system.com).
2 - adding some #ifdef CONFIG_PEAK_PCIEC/ #endif in peak_pci.c around
all what concerns leds management.
What is your opinion?
Regards,
Stéphane
--
PEAK-System Technik GmbH, Otto-Roehm-Strasse 69, D-64293 Darmstadt
Geschaeftsleitung: A.Gach/U.Wilhelm,St.Nr.:007/241/13586 FA Darmstadt
HRB-9183 Darmstadt, Ust.IdNr.:DE 202220078, WEE-Reg.-Nr.: DE39305391
Tel.+49 (0)6151-817320 / Fax:+49 (0)6151-817329, info@peak-system.com
next prev parent reply other threads:[~2012-02-01 12:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 11:02 [PATCH v3] peak_pci: add support for PEAK-System PCIe/PCIeC/miniPCI boards Stephane Grosjean
2012-02-01 12:02 ` Wolfgang Grandegger
2012-02-01 12:29 ` Stephane Grosjean [this message]
2012-02-01 13:46 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F293035.2060201@peak-system.com \
--to=s.grosjean@peak-system.com \
--cc=linux-can@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).