From: Wolfgang Grandegger <wg@grandegger.com>
To: s.grosjean@peak-system.com
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
linux-can Mailing List <linux-can@vger.kernel.org>
Subject: Re: [PATCH v4] peak_pci: add support for PEAK-System PCIe/PCIeC/miniPCI cards
Date: Wed, 01 Feb 2012 17:45:02 +0100 [thread overview]
Message-ID: <4F296C0E.7030106@grandegger.com> (raw)
In-Reply-To: <4F296A39.60709@peak-system.com>
On 02/01/2012 05:37 PM, Stephane Grosjean wrote:
> Le 01/02/2012 17:14, Wolfgang Grandegger a écrit :
>>
>> Yes, static inline functions please. I think we should have:
>>
>> #if defined(CONFIG_I2C_ALGOBIT) || defined(CONFIG_I2C_ALGOBIT_MODULE)
>> /* or a real option selecting the LED support */
>>
>> ... one ifdef block with the real implementation ...
>> #else
>> static inline int peak_pciec_led_init(...) {return -EINVAL;}
>> static inline void peak_pciec_led_init(...) {}
>> #endif
>
> Well, there was/is some confusion indeed: I thought #ifdef/#endif blocks
> were not welcome in code (that's the reason of the i2c_xxx() #defines)
> If I'm allowed to use at least one, the above option looks ok for me.
Well, we need at least one #ifdef somewhere if we do not want to use a
registration framework, I think. I will have a closer look to the driver
later on my way home...
Wolfgang.
prev parent reply other threads:[~2012-02-01 16:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 14:57 [PATCH v4] peak_pci: add support for PEAK-System PCIe/PCIeC/miniPCI cards Stephane Grosjean
2012-02-01 15:21 ` Marc Kleine-Budde
2012-02-01 15:34 ` Wolfgang Grandegger
2012-02-01 16:04 ` Stephane Grosjean
2012-02-01 16:19 ` Wolfgang Grandegger
2012-02-01 15:48 ` Marc Kleine-Budde
2012-02-01 15:55 ` Stephane Grosjean
2012-02-01 15:57 ` Marc Kleine-Budde
2012-02-01 16:12 ` Stephane Grosjean
2012-02-01 16:14 ` Wolfgang Grandegger
2012-02-01 16:37 ` Stephane Grosjean
2012-02-01 16:45 ` Wolfgang Grandegger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F296C0E.7030106@grandegger.com \
--to=wg@grandegger.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=s.grosjean@peak-system.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).