Re: [PATCH v4.3] peak_pci: add support for PEAK-System PCIe/PCIeC/miniPCI cards

[Oliver Hartkopp <socketcan@hartkopp.net>]

Hello Stephane et.al.

On 02.02.2012 14:19, Stephane Grosjean wrote:

>  
>  config CAN_PEAK_PCI
> -	tristate "PEAK PCAN PCI/PCIe Cards"
> +	tristate "PEAK PCAN-PCI/PCIe/PCIeC/miniPCI Cards"
>  	depends on PCI
>  	---help---
> -	  This driver is for the PCAN PCI/PCIe cards (1, 2, 3 or 4 channels)
> -	  from PEAK Systems (http://www.peak-system.com).
> +	  This driver is for the PCAN-PCI/PCIe/PCIeC/miniPCI cards
> +	  (1, 2, 3 or 4 channels) from PEAK-System Technik
> +	  (http://www.peak-system.com).
> +
> +	  The I2C bit-banging algorithm should be selected to enable
> +	  correct LEDs management on the PCAN-ExpressCard (PCIeC) card.


The problem is that the PCAN-ExpressCards without galvanic isolation
(IPEH-003000, IPEH-003001) are not working at all when the I2C stuff is not
initialized.

It's not only the LED handling.

What about this:

 config CAN_PEAK_PCI
	tristate "PEAK PCAN-PCI/PCIe/miniPCI Cards"
	depends on PCI
	---help---
	  This driver is for the PCAN PCI/PCIe cards (1, 2, 3 or 4 channels)
	  from PEAK Systems (http://www.peak-system.com).
	  This driver is for the PCAN-PCI/PCIe/PCIeC/miniPCI cards
	  (1, 2, 3 or 4 channels) from PEAK-System Technik
	  (http://www.peak-system.com).

	  The I2C bit-banging algorithm (I2C ALGOBIT) needs to be selected to
	  support PCAN-ExpressCard (PCIeC) cards.

 config CAN_PEAK_PCIEC
	tristate "PEAK PCAN-Express Cards"
	depends on CAN_PEAK_PCI && CONFIG_I2C_ALGOBIT
	---help---
	  (bla bla)

(..)


>  
>  MODULE_DEVICE_TABLE(pci, peak_pci_tbl);
>  
> +#if defined(CONFIG_I2C_ALGOBIT) || defined(CONFIG_I2C_ALGOBIT_MODULE)


#ifdef CONFIG_CAN_PEAK_PCIEC

(..)

Regards,
Oliver