Re: [PATCH v4.3] peak_pci: add support for PEAK-System PCIe/PCIeC/miniPCI cards

[Stephane Grosjean <s.grosjean@peak-system.com>]

Le 03/02/2012 00:06, Oliver Hartkopp a écrit :
> On 02.02.2012 19:03, Oliver Hartkopp wrote:
>
>> The problem is that the PCAN-ExpressCards without galvanic isolation
>> (IPEH-003000, IPEH-003001) are not working at all when the I2C stuff is not
>> initialized.
>>
>> It's not only the LED handling.

Yes you're right: the existing code already enables the can transceiver, 
but I forgot that it used a led pin, sorry.

>> Alternatively you may just select I2C and I2C_ALGOBIT as it is done by other
>> drivers like this:
>>
>> http://lxr.linux.no/#linux+v3.2.2/drivers/net/ethernet/sfc/Kconfig#L7
>>
>> config CAN_PEAK_PCI
>> 	tristate "PEAK PCAN-PCI/PCIe/PCIeC/miniPCI Cards"
>> 	depends on PCI
>> 	select I2C
>> 	select I2C_ALGOBIT
>> 	---help---
>> 	  This driver is for the PCAN-PCI/PCIe/PCIeC/miniPCI cards
>> 	  (1, 2, 3 or 4 channels) from PEAK-System Technik
>> 	  (http://www.peak-system.com).
>>
>> ... which would also make the #ifdef stuff obsolete.

Well, if this is used in an already existing driver, we can suppose that 
this is the correct way to do that.
I personally prefer the "select" way of doing things rather than the 
"depends on".

Do someone disagree with?

Moreover, no response about my question of yesterday: since I have to 
post another (pcmcia) driver for the sja1000 subdir (and thus, change 
the Kconfig again), the best solution would be to post all through a 
serie of patches, wouldn't it?

Thanks for your reply,

Stéphane

--
PEAK-System Technik GmbH, Otto-Roehm-Strasse 69, D-64293 Darmstadt 
Geschaeftsleitung: A.Gach/U.Wilhelm,St.Nr.:007/241/13586 FA Darmstadt 
HRB-9183 Darmstadt, Ust.IdNr.:DE 202220078, WEE-Reg.-Nr.: DE39305391 
Tel.+49 (0)6151-817320 / Fax:+49 (0)6151-817329, info@peak-system.com