From: Wolfgang Grandegger <wg@grandegger.com>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Stephane Grosjean <s.grosjean@peak-system.com>,
linux-can Mailing List <linux-can@vger.kernel.org>
Subject: Re: [PATCH v4.3] peak_pci: add support for PEAK-System PCIe/PCIeC/miniPCI cards
Date: Fri, 03 Feb 2012 11:19:04 +0100 [thread overview]
Message-ID: <4F2BB498.60606@grandegger.com> (raw)
In-Reply-To: <4F2B16F9.8020903@hartkopp.net>
On 02/03/2012 12:06 AM, Oliver Hartkopp wrote:
> On 02.02.2012 19:03, Oliver Hartkopp wrote:
>
>> Hello Stephane et.al.
>>
>> On 02.02.2012 14:19, Stephane Grosjean wrote:
>>
>>>
>>> config CAN_PEAK_PCI
>>> - tristate "PEAK PCAN PCI/PCIe Cards"
>>> + tristate "PEAK PCAN-PCI/PCIe/PCIeC/miniPCI Cards"
>>> depends on PCI
>>> ---help---
>>> - This driver is for the PCAN PCI/PCIe cards (1, 2, 3 or 4 channels)
>>> - from PEAK Systems (http://www.peak-system.com).
>>> + This driver is for the PCAN-PCI/PCIe/PCIeC/miniPCI cards
>>> + (1, 2, 3 or 4 channels) from PEAK-System Technik
>>> + (http://www.peak-system.com).
>>> +
>>> + The I2C bit-banging algorithm should be selected to enable
>>> + correct LEDs management on the PCAN-ExpressCard (PCIeC) card.
>>
>>
>> The problem is that the PCAN-ExpressCards without galvanic isolation
>> (IPEH-003000, IPEH-003001) are not working at all when the I2C stuff is not
>> initialized.
If that is true...
>>
>> It's not only the LED handling.
>>
>> What about this:
>>
>> config CAN_PEAK_PCI
>> tristate "PEAK PCAN-PCI/PCIe/miniPCI Cards"
>> depends on PCI
>> ---help---
>> This driver is for the PCAN PCI/PCIe cards (1, 2, 3 or 4 channels)
>> from PEAK Systems (http://www.peak-system.com).
>> This driver is for the PCAN-PCI/PCIe/PCIeC/miniPCI cards
>> (1, 2, 3 or 4 channels) from PEAK-System Technik
>> (http://www.peak-system.com).
>>
>> The I2C bit-banging algorithm (I2C ALGOBIT) needs to be selected to
>> support PCAN-ExpressCard (PCIeC) cards.
>>
>> config CAN_PEAK_PCIEC
>> tristate "PEAK PCAN-Express Cards"
>> depends on CAN_PEAK_PCI && CONFIG_I2C_ALGOBIT
>
>
> ... sorry : of course without CONFIG_
>
> just
>
> config CAN_PEAK_PCIEC
> bool "PEAK PCAN-Express Cards"
> depends on CAN_PEAK_PCI && I2C_ALGOBIT
> default y
>
>
>> ---help---
>
>> (bla bla)
... I definitely prefer that solution. It's more transparent and it also
allows to drop support for the PCIEC on embedded boards if there is no
PCI express slot. Furthermore, it does require little modifications to
the v4.3 patch.
Wolfgang.
next prev parent reply other threads:[~2012-02-03 10:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 13:19 [PATCH v4.3] peak_pci: add support for PEAK-System PCIe/PCIeC/miniPCI cards Stephane Grosjean
2012-02-02 18:03 ` Oliver Hartkopp
2012-02-02 23:06 ` Oliver Hartkopp
2012-02-03 10:14 ` Stephane Grosjean
2012-02-03 10:19 ` Wolfgang Grandegger [this message]
2012-02-03 10:44 ` Stephane Grosjean
2012-02-03 10:59 ` Wolfgang Grandegger
2012-02-03 11:34 ` Stephane Grosjean
2012-02-03 12:01 ` Stephane Grosjean
2012-02-03 12:28 ` Wolfgang Grandegger
2012-02-03 13:02 ` Stephane Grosjean
2012-02-03 12:09 ` Stephane Grosjean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2BB498.60606@grandegger.com \
--to=wg@grandegger.com \
--cc=linux-can@vger.kernel.org \
--cc=s.grosjean@peak-system.com \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).