Re: [PATCH v4.3] peak_pci: add support for PEAK-System PCIe/PCIeC/miniPCI cards

[Wolfgang Grandegger <wg@grandegger.com>]

On 02/03/2012 11:44 AM, Stephane Grosjean wrote:
> Le 03/02/2012 11:19, Wolfgang Grandegger a écrit :
>> On 02/03/2012 12:06 AM, Oliver Hartkopp wrote:
>>> On 02.02.2012 19:03, Oliver Hartkopp wrote:
>>>
>>>
>>> The problem is that the PCAN-ExpressCards without galvanic isolation
>>> (IPEH-003000, IPEH-003001) are not working at all when the I2C stuff
>>> is not
>>> initialized.
>> If that is true...
> 
> Yes this is true but for PCAN-ExpressCard without galvanic isolation
> only, that is, PCAN-ExpressCard with galvanic isolation won't need I2C
> stuff..
> 
>> What about this:
>>
>>   config CAN_PEAK_PCI
>>     tristate "PEAK PCAN-PCI/PCIe/miniPCI Cards"
>>     depends on PCI
>>     ---help---
>>       This driver is for the PCAN PCI/PCIe cards (1, 2, 3 or 4 channels)
>>       from PEAK Systems (http://www.peak-system.com).
>>       This driver is for the PCAN-PCI/PCIe/PCIeC/miniPCI cards
>>       (1, 2, 3 or 4 channels) from PEAK-System Technik
>>       (http://www.peak-system.com).
>>
>>       The I2C bit-banging algorithm (I2C ALGOBIT) needs to be selected to
>>       support PCAN-ExpressCard (PCIeC) cards.
>>
>>
>>    config CAN_PEAK_PCIEC
>>       bool "PEAK PCAN-Express Cards"
>>       depends on CAN_PEAK_PCI&&  I2C_ALGOBIT
>>       default y
> 
> So, I think that the following is closer to the truth:
> 
>  config CAN_PEAK_PCI
> -    tristate "PEAK PCAN-PCI/PCIe/miniPCI Cards"
> +    tristate "PEAK PCAN-PCI/PCIe/PCIeC/miniPCI Cards"
>     depends on PCI
>     ---help---
>       This driver is for the PCAN-PCI/PCIe/PCIeC/miniPCI cards
>       (1, 2, 3 or 4 channels) from PEAK-System Technik
>       (http://www.peak-system.com).
> 
>       The I2C bit-banging algorithm (I2C ALGOBIT) needs to be selected to
> -      support PCAN-ExpressCard (PCIeC) cards.
> +      support PCAN-ExpressCard cards models without galvanic isolation
> +       that is, IPEH-003000 and IPEH-003001.
> 
>  config CAN_PEAK_PCIEC_I2C
> +     bool "PEAK non-isolated PCAN-ExpressCard Cards"
>      depends on CAN_PEAK_PCI&&  I2C_ALGOBIT
>      default y
> +    ---help---
> +        Say Y here if your PEAK-System Technik PCAN-ExpressCard is not
> equipped
> +        with any galvanic isolation (IPEH-003000 and IPEH-003001)  .
> 
> 
> (sorry for the manual-made patch style)

Well, that is even more confusing. What happens if there is no LED
support. If the LEDs are not blinking or illuminated users might think
the card is not working. I would go for CAN_PEAK_PCIEC config enabling
the support for the PCIEC *explicitly*. I mean, no support for the PCIEC
if CAN_PEAK_PCIEC is not enabled. You may want to use the select trick
if you prefer on that config. What do the others think?

Wolfgang.